Add warning when building AWS Lambdas and Google Cloud Functions on macOS. #13790
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
riisi
changed the title
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
Thanks for the feedback :) Updated now. |
| @@ -54,6 +55,17 @@ class PythonAwsLambdaFieldSet(PackageFieldSet): | |||
| async def package_python_awslambda( | |||
| field_set: PythonAwsLambdaFieldSet, lambdex: Lambdex, union_membership: UnionMembership | |||
| ) -> BuiltPackage: | |||
|
|
|||
| if Platform.is_macos: | |||
| logger.warning( | |||
There was a problem hiding this comment.
This might be useful information if the packing fails, but it's otherwise continual noise every time this is run and packaging succeeds. How about switching to a FallibleProcessResult and then conditioning this warning on both macOS and process failure?
There was a problem hiding this comment.
Agreed that would be a superior experience.
Per discussion at #11941, implementing it is trickier. We need to
- Add a
FalliblePextype - Allow augmenting a
ProcessExecutionFailurewith additional details.- I started on this last week as part of go: suggesting
go mod tidymay not always work #13136, but Benjy and I decided to punt on the ticket and the design work of how to show the extra info.
- I started on this last week as part of go: suggesting
So I suggested that using a warning is a good first start to get some progress.
There was a problem hiding this comment.
Erm. Ok. I'm not a fan of bridging the gap with noise, but looks like others are.
There was a problem hiding this comment.
Opened #13865 to track that second task.
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
|
Thanks for this contribution! |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Fixes #11941.
[ci skip-rust]
[ci skip-build-wheels]