Add symlinked immutable Process inputs #13848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
force-pushed
the
stuhood/immutable-caches
branch
2 times, most recently
from
d5fa12c
to
16d4cb4
Compare
stuhood
force-pushed
the
stuhood/immutable-caches
branch
2 times, most recently
from
bff632b
to
3a9593b
Compare
|
This should now be ready for review. The first six commits include work from @tdyas, and are probably easiest reviewed as one diff (since I went back and forth a few times and renamed the field), and the last commit is useful to look at independently. |
stuhood
commented
Dec 9, 2021
jsirois
approved these changes
Dec 10, 2021
tdyas
approved these changes
Dec 10, 2021
This was referenced Dec 10, 2021
stuhood
force-pushed
the
stuhood/immutable-caches
branch
2 times, most recently
from
321b2e5
to
fd9a9e5
Compare
[ci skip-build-wheels]
[ci skip-build-wheels]
[ci skip-build-wheels]
[ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
… list of `immutable_inputs` paths. [ci skip-build-wheels]
[ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/immutable-caches
branch
from
fd9a9e5
to
3763167
Compare
[ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/immutable-caches
branch
from
3763167
to
342f5f0
Compare
stuhood
added a commit
that referenced
this pull request
Dec 13, 2021
…3862) As described in #13435, we expect large sandboxes for JVM compiles (for Scala in particular). #13848 added support for symlinking immutable inputs into sandboxes, and used it for tools. This change uses it for JVM classpaths as well. In a test repo, this reduces the total amount of time taken to create sandboxes for compilation by ~30% (from 14s to 10s), with an average sandbox creation time of 40ms (including amortized materialization of the symlink destinations). [ci skip-rust] [ci skip-build-wheels]
Merged
This was referenced Dec 13, 2021
This was referenced Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As designed by @tdyas in #12716, this change adds
immutable_inputstoProcess, and adapts the JVM@rulesto use them: for now, only for the tools themselves. A followup change will move all JVM classpath inputs toimmutable_inputs.Nailgun support is now enabled by specifying the subset of the
immutable_inputswhich should be used to start the server: all others will be used to start the client.[ci skip-build-wheels]