[internal] Introduce new `BuiltinGoal` subsystem type. #13991

kaos · 2021-12-27T09:50:29Z

Refactoring how the help system is integrated with the arg spllitter, to open up for adding more builtin goals without bloating the arg splitter by introducing a new BuiltinGoal subsystem type.

This is a stab at addressing this comment from @stuhood

So cleaning up the support that builtin goals have for subcommands would definitely be welcome.
#13694 (comment)

By addressing first how the help goal is integrated.

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]

kaos

This is kind of in draft shape, but I'd like review feedback to help guide further direction for this work.

src/python/pants/engine/internals/builtin_goal.py

src/python/pants/goal/help.py

src/python/pants/help/help_info_extracter.py

kaos · 2021-12-27T10:11:03Z

src/python/pants/option/arg_splitter.py

@@ -282,6 +263,7 @@ def _at_flag(self) -> bool:
            bool(self._unconsumed_args)
            and self._unconsumed_args[-1].startswith("-")
            and not self._at_double_dash()
+            and not self._at_scope()


Some built in goals have aliases that is a flag, so we need to treat those aliases as goals, not flags.

kaos · 2021-12-27T10:12:09Z

src/python/pants/option/arg_splitter_test.py

-    UnknownGoalHelp,
-    VersionHelp,
-)
+from pants.core.register import builtin_goals


Not great. As the help integration has moved out of arg splitter, the tests for the help integration ought to move as well..

src/python/pants/option/arg_splitter_test.py

kaos · 2021-12-27T10:16:26Z

src/python/pants/option/arg_splitter_test.py

+            "./pants --help-advanced", "help-advanced", expected_help_advanced=True
+        ),
+        help_no_arguments_test(
+            "./pants --help --help-advanced", "help", "help-advanced", expected_help_advanced=True


This has now changed behaviour (which we may want to restore/fix): that the regular help will be picked up before the help-advanced, and as such, you only get the basic help, not the advanced.

kaos · 2021-12-27T10:18:08Z

src/python/pants/option/scope.py

    def _subsystem_cls_attr(self, name: str, default=None):
-        return getattr(self.subsystem_cls, name) if self.subsystem_cls else default
+        return getattr(self.subsystem_cls, name, default) if self.subsystem_cls else default


Not all subsystem classes have the aliases attribute, and since we always return a default any way, it felt safe to provide that default already to getattr.

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

kaos · 2021-12-27T15:56:20Z

PR showcasing what a list-backends built in goal could look like.. :) (and also surfaced an issue with invoking the help goal on built in goals.. it does nothing when it should present the help info for the goal)
kaos#1

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

stuhood

Thanks for the ideas here!

I think that my biggest concern is: I don't think that this should be a new extension point for plugin authors, and so I only think that it needs to be powerful enough to accomplish the goals of Pants core. Right now that is #11167... and I'm not aware of any other planned builtin goals in the core (although would be curious to hear about them).

So while the refactoring is welcome, some of the speculative features around chaining or mutating the inputs are too powerful for the problems these are solving.

src/python/pants/core/register.py

src/python/pants/engine/internals/builtin_goal.py

stuhood · 2022-01-05T17:58:11Z

src/python/pants/option/arg_splitter.py

-            elif arg not in self._known_scopes:
-                unknown_scopes.append(arg)
+            else:
+                add_goal(arg)


IMO, it would be better to error for any goals following a builtin goal. Unless there is a really compelling case for builtin goals "modifying" @goal_rules, things like ./pants gc lint and ./pants help lint fmt are just confusing (I think that the latter would run help lint and then fmt things...?).

For one thing, it seems like that would allow for an implementation where as soon as we encountered the token for a builtin goal on the CLI, we could effectively hand the rest of the arguments (completely unmodified) to the goal. That would lose the ability to do things like ./pants help $subsystem --global-option ... but that doesn't seem too bad.

….goal.builtins

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

kaos

tweaked from previews review, thanks! :) cc @stuhood

kaos · 2022-01-06T16:46:12Z

src/python/pants/init/extension_loader.py

@@ -40,6 +41,7 @@ def load_backends_and_plugins(
    bc_builder = bc_builder or BuildConfiguration.Builder()
    load_build_configuration_from_source(bc_builder, backends)
    load_plugins(bc_builder, plugins, working_set)
+    register_builtin_goals(bc_builder)


Explicitly register our built in goals. Not configurable/extensible.

src/python/pants/option/arg_splitter_test.py

Eric-Arellano

Cool!

src/python/pants/goal/help.py

src/python/pants/goal/builtins.py

src/python/pants/option/arg_splitter.py

src/python/pants/option/arg_splitter_test.py

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

kaos · 2022-01-06T22:10:07Z

I'll wait for @stuhood to make another review too before landing, to make sure I have covered his earlier feedback.

kaos · 2022-01-07T09:45:58Z

I realise now that this change is marked [internal], but it does affect subtly the semantics of the builtin help command line options.. that is ./pants help foo --help-advanced doesn't behave the same after this change as before, for instance (it will give you non advanced help for foo, and say it doesn't know of the thing --help-advanced, rather than giving advanced help on foo).

The advanced help as documented works the same, so I think this could be simply aligning on that and getting rid of some interesting side effects of allowing the use of --help and --help-advanced as post fix use on a goal, rather than leading with it, so that ./pants foo --help is valid just as ./pants help foo (i.e. this works the same as before).

cc FYI @benjyw

Example:

$ ./pants help docker --help-advanced
Unknown entity: --help-advanced

`docker` subsystem options
--------------------------

Options for interacting with Docker.
 
Activated by pants.backend.experimental.docker
Config section: [docker]
 
  --docker-registries="{'key1': val1, 'key2': val2, ...}"
[...]

$ ./pants docker --help-advanced

`docker` subsystem options
--------------------------

Options for interacting with Docker.
 
Activated by pants.backend.experimental.docker
Config section: [docker]
 
  --docker-registries="{'key1': val1, 'key2': val2, ...}"
[...]
`docker` subsystem advanced options
-----------------------------------
 
  --docker-env-vars="[<shell_str>, <shell_str>, ...]"
[...]

Eric-Arellano · 2022-01-07T16:24:12Z

that is ./pants help foo --help-advanced doesn't behave the same after this change as before

I'm not that worried about this. It was always a corner case that users seem unlikely to do. And it's somewhat intuitive how to work around it.

kaos · 2022-01-10T22:19:08Z

Ping @stuhood

stuhood · 2022-01-10T23:34:01Z

@kaos : Did you see https://github.com/pantsbuild/pants/pull/13991/files#r779923457 ? I might have made a bad suggestion: wondering what your thoughts were there.

kaos · 2022-01-11T09:36:38Z

Ah, thanks. No, I had overlooked that one.

kaos · 2022-01-11T11:30:39Z

src/python/pants/option/arg_splitter_test.py

            expected_specs=[],
        ),
        help_test(
            "./pants help check -x",
            expected_goals=["check"],
-            expected_scope_to_flags={"": [], "check": ["-x"]},
+            expected_scope_to_flags={"": [], "help": ["-x"], "check": []},


My reasoning here is that I see ./pants help check -x as ./pants help <thing[s]...> <help option[s]...>
As shown in a previous test, you can provide options for the thing you ask help on, by including its scope:

./pants help check --check-x

stuhood

Thanks a lot!

Internal changes: * upgrade to Rust v1.58.0 ([pantsbuild#14174](pantsbuild#14174)) * [internal] fix typos in codegen registration ([pantsbuild#14172](pantsbuild#14172)) * Remove per-language indirection for formatter plugins. ([pantsbuild#14166](pantsbuild#14166)) * Pulls `Coordinate` and `ArtifactRequirements` out into a separate file to avoid a circuilar import later ([pantsbuild#14164](pantsbuild#14164)) * Factors lockfile metadata code into class that supports multiple languages as well as versions ([pantsbuild#14116](pantsbuild#14116)) * Adds `.env` file to make vscode auto-imports work correctly out of the box ([pantsbuild#14130](pantsbuild#14130)) * [internal] Rename classes for `generate_lockfiles.py` for clarity ([pantsbuild#14218](pantsbuild#14218)) * [internal] Fix bad Find+Replace ([pantsbuild#14213](pantsbuild#14213)) * [internal] Bump libc from 0.2.106 to 0.2.112 in /src/rust/engine ([pantsbuild#14206](pantsbuild#14206)) * [internal] Bump tempfile from 3.2.0 to 3.3.0 in /src/rust/engine ([pantsbuild#14202](pantsbuild#14202)) * [internal] Bump criterion from 0.3.3 to 0.3.5 in /src/rust/engine ([pantsbuild#14205](pantsbuild#14205)) * [internal] Bump walkdir from 2.3.1 to 2.3.2 in /src/rust/engine ([pantsbuild#14204](pantsbuild#14204)) * [internal] Bump generic-array from 0.14.4 to 0.14.5 in /src/rust/engine ([pantsbuild#14203](pantsbuild#14203)) * [internal] Remove the minimum bucket size of batching to improve stability. ([pantsbuild#14210](pantsbuild#14210)) * [internal] Make `JvmLockfileRequest` generic ([pantsbuild#14201](pantsbuild#14201)) * [internal] add comment re clippy issue ([pantsbuild#14188](pantsbuild#14188)) * [internal] rename some codegen scopes to put language first ([pantsbuild#14187](pantsbuild#14187)) * [internal] Check for ambiguity when running `generate-lockfiles` ([pantsbuild#14178](pantsbuild#14178)) * [internal] Change JVM lockfile format ([pantsbuild#14175](pantsbuild#14175)) * [internal] go: rewrite third party package analysis to not use `go list` ([pantsbuild#14157](pantsbuild#14157)) * [internal] Hotfix `fmt` crashing on non-formattable targets ([pantsbuild#14168](pantsbuild#14168)) * [internal] Simplify `core/goals/package.py` filesystem API usage ([pantsbuild#14162](pantsbuild#14162)) * [internal] java/thrift: register union that was not registered ([pantsbuild#14159](pantsbuild#14159)) * [internal] Bump arc-swap from 1.3.0 to 1.5.0 in /src/rust/engine ([pantsbuild#14148](pantsbuild#14148)) * [internals] Bump tokio-rustls from 0.22.0 to 0.23.2 in /src/rust/engine ([pantsbuild#14149](pantsbuild#14149)) * [internal] Bump num_cpus from 1.13.0 to 1.13.1 in /src/rust/engine ([pantsbuild#14150](pantsbuild#14150)) * [internal] Bump tokio-util from 0.6.7 to 0.6.9 in /src/rust/engine ([pantsbuild#14151](pantsbuild#14151)) * [internal] Bump os_pipe from 0.9.2 to 1.0.0 in /src/rust/engine ([pantsbuild#14152](pantsbuild#14152)) * [internal] Introduce new `BuiltinGoal` subsystem type. ([pantsbuild#13991](pantsbuild#13991)) * [internal] Upgrade python type stubs packages ([pantsbuild#14143](pantsbuild#14143)) * [internal] Bump strum_macros from 0.20.1 to 0.23.1 in /src/rust/engine ([pantsbuild#14141](pantsbuild#14141)) * [internal] Make `generate-lockfiles` goal generic ([pantsbuild#14122](pantsbuild#14122)) * [internal] Bump errno from 0.2.7 to 0.2.8 in /src/rust/engine ([pantsbuild#14137](pantsbuild#14137)) * [internal] Bump colored from 1.9.3 to 2.0.0 in /src/rust/engine ([pantsbuild#14138](pantsbuild#14138)) * [internal] Bump crossbeam-channel from 0.4.4 to 0.5.0 in /src/rust/engine ([pantsbuild#14139](pantsbuild#14139)) * [internal] Bump reqwest from 0.11.4 to 0.11.9 in /src/rust/engine ([pantsbuild#14135](pantsbuild#14135)) * [internal] Further tweak dependabot config ([pantsbuild#14132](pantsbuild#14132)) * [internal] python: use immutable_input_digests for protobuf codegen ([pantsbuild#13885](pantsbuild#13885)) * [internal] python: use immutable_input_digests for protobuf codegen ([pantsbuild#13885](pantsbuild#13885)) * [internal] No need for two f-strings/two strings. ([pantsbuild#14119](pantsbuild#14119))

Internal changes: * upgrade to Rust v1.58.0 ([pantsbuild#14174](pantsbuild#14174)) * [internal] fix typos in codegen registration ([pantsbuild#14172](pantsbuild#14172)) * Pulls `Coordinate` and `ArtifactRequirements` out into a separate file to avoid a circuilar import later ([pantsbuild#14164](pantsbuild#14164)) * Factors lockfile metadata code into class that supports multiple languages as well as versions ([pantsbuild#14116](pantsbuild#14116)) * Adds `.env` file to make vscode auto-imports work correctly out of the box ([pantsbuild#14130](pantsbuild#14130)) * [internal] Rename classes for `generate_lockfiles.py` for clarity ([pantsbuild#14218](pantsbuild#14218)) * [internal] Fix bad Find+Replace ([pantsbuild#14213](pantsbuild#14213)) * [internal] Bump libc from 0.2.106 to 0.2.112 in /src/rust/engine ([pantsbuild#14206](pantsbuild#14206)) * [internal] Bump tempfile from 3.2.0 to 3.3.0 in /src/rust/engine ([pantsbuild#14202](pantsbuild#14202)) * [internal] Bump criterion from 0.3.3 to 0.3.5 in /src/rust/engine ([pantsbuild#14205](pantsbuild#14205)) * [internal] Bump walkdir from 2.3.1 to 2.3.2 in /src/rust/engine ([pantsbuild#14204](pantsbuild#14204)) * [internal] Bump generic-array from 0.14.4 to 0.14.5 in /src/rust/engine ([pantsbuild#14203](pantsbuild#14203)) * [internal] Remove the minimum bucket size of batching to improve stability. ([pantsbuild#14210](pantsbuild#14210)) * [internal] Make `JvmLockfileRequest` generic ([pantsbuild#14201](pantsbuild#14201)) * [internal] add comment re clippy issue ([pantsbuild#14188](pantsbuild#14188)) * [internal] rename some codegen scopes to put language first ([pantsbuild#14187](pantsbuild#14187)) * [internal] Check for ambiguity when running `generate-lockfiles` ([pantsbuild#14178](pantsbuild#14178)) * [internal] Change JVM lockfile format ([pantsbuild#14175](pantsbuild#14175)) * [internal] go: rewrite third party package analysis to not use `go list` ([pantsbuild#14157](pantsbuild#14157)) * [internal] Hotfix `fmt` crashing on non-formattable targets ([pantsbuild#14168](pantsbuild#14168)) * [internal] Simplify `core/goals/package.py` filesystem API usage ([pantsbuild#14162](pantsbuild#14162)) * [internal] java/thrift: register union that was not registered ([pantsbuild#14159](pantsbuild#14159)) * [internal] Bump arc-swap from 1.3.0 to 1.5.0 in /src/rust/engine ([pantsbuild#14148](pantsbuild#14148)) * [internals] Bump tokio-rustls from 0.22.0 to 0.23.2 in /src/rust/engine ([pantsbuild#14149](pantsbuild#14149)) * [internal] Bump num_cpus from 1.13.0 to 1.13.1 in /src/rust/engine ([pantsbuild#14150](pantsbuild#14150)) * [internal] Bump tokio-util from 0.6.7 to 0.6.9 in /src/rust/engine ([pantsbuild#14151](pantsbuild#14151)) * [internal] Bump os_pipe from 0.9.2 to 1.0.0 in /src/rust/engine ([pantsbuild#14152](pantsbuild#14152)) * [internal] Introduce new `BuiltinGoal` subsystem type. ([pantsbuild#13991](pantsbuild#13991)) * [internal] Upgrade python type stubs packages ([pantsbuild#14143](pantsbuild#14143)) * [internal] Bump strum_macros from 0.20.1 to 0.23.1 in /src/rust/engine ([pantsbuild#14141](pantsbuild#14141)) * [internal] Make `generate-lockfiles` goal generic ([pantsbuild#14122](pantsbuild#14122)) * [internal] Bump errno from 0.2.7 to 0.2.8 in /src/rust/engine ([pantsbuild#14137](pantsbuild#14137)) * [internal] Bump colored from 1.9.3 to 2.0.0 in /src/rust/engine ([pantsbuild#14138](pantsbuild#14138)) * [internal] Bump crossbeam-channel from 0.4.4 to 0.5.0 in /src/rust/engine ([pantsbuild#14139](pantsbuild#14139)) * [internal] Bump reqwest from 0.11.4 to 0.11.9 in /src/rust/engine ([pantsbuild#14135](pantsbuild#14135)) * [internal] Further tweak dependabot config ([pantsbuild#14132](pantsbuild#14132)) * [internal] python: use immutable_input_digests for protobuf codegen ([pantsbuild#13885](pantsbuild#13885)) * [internal] python: use immutable_input_digests for protobuf codegen ([pantsbuild#13885](pantsbuild#13885)) * [internal] No need for two f-strings/two strings. ([pantsbuild#14119](pantsbuild#14119)) * `LockfileMetadata` - Replace flaky `_header_dict()` mechanism with more robust `header_attrs` mechanism ([pantsbuild#14229](pantsbuild#14229))

Internal changes: * upgrade to Rust v1.58.0 ([#14174](#14174)) * [internal] fix typos in codegen registration ([#14172](#14172)) * Pulls `Coordinate` and `ArtifactRequirements` out into a separate file to avoid a circuilar import later ([#14164](#14164)) * Factors lockfile metadata code into class that supports multiple languages as well as versions ([#14116](#14116)) * Adds `.env` file to make vscode auto-imports work correctly out of the box ([#14130](#14130)) * [internal] Rename classes for `generate_lockfiles.py` for clarity ([#14218](#14218)) * [internal] Fix bad Find+Replace ([#14213](#14213)) * [internal] Bump libc from 0.2.106 to 0.2.112 in /src/rust/engine ([#14206](#14206)) * [internal] Bump tempfile from 3.2.0 to 3.3.0 in /src/rust/engine ([#14202](#14202)) * [internal] Bump criterion from 0.3.3 to 0.3.5 in /src/rust/engine ([#14205](#14205)) * [internal] Bump walkdir from 2.3.1 to 2.3.2 in /src/rust/engine ([#14204](#14204)) * [internal] Bump generic-array from 0.14.4 to 0.14.5 in /src/rust/engine ([#14203](#14203)) * [internal] Remove the minimum bucket size of batching to improve stability. ([#14210](#14210)) * [internal] Make `JvmLockfileRequest` generic ([#14201](#14201)) * [internal] add comment re clippy issue ([#14188](#14188)) * [internal] rename some codegen scopes to put language first ([#14187](#14187)) * [internal] Check for ambiguity when running `generate-lockfiles` ([#14178](#14178)) * [internal] Change JVM lockfile format ([#14175](#14175)) * [internal] go: rewrite third party package analysis to not use `go list` ([#14157](#14157)) * [internal] Hotfix `fmt` crashing on non-formattable targets ([#14168](#14168)) * [internal] Simplify `core/goals/package.py` filesystem API usage ([#14162](#14162)) * [internal] java/thrift: register union that was not registered ([#14159](#14159)) * [internal] Bump arc-swap from 1.3.0 to 1.5.0 in /src/rust/engine ([#14148](#14148)) * [internals] Bump tokio-rustls from 0.22.0 to 0.23.2 in /src/rust/engine ([#14149](#14149)) * [internal] Bump num_cpus from 1.13.0 to 1.13.1 in /src/rust/engine ([#14150](#14150)) * [internal] Bump tokio-util from 0.6.7 to 0.6.9 in /src/rust/engine ([#14151](#14151)) * [internal] Bump os_pipe from 0.9.2 to 1.0.0 in /src/rust/engine ([#14152](#14152)) * [internal] Introduce new `BuiltinGoal` subsystem type. ([#13991](#13991)) * [internal] Upgrade python type stubs packages ([#14143](#14143)) * [internal] Bump strum_macros from 0.20.1 to 0.23.1 in /src/rust/engine ([#14141](#14141)) * [internal] Make `generate-lockfiles` goal generic ([#14122](#14122)) * [internal] Bump errno from 0.2.7 to 0.2.8 in /src/rust/engine ([#14137](#14137)) * [internal] Bump colored from 1.9.3 to 2.0.0 in /src/rust/engine ([#14138](#14138)) * [internal] Bump crossbeam-channel from 0.4.4 to 0.5.0 in /src/rust/engine ([#14139](#14139)) * [internal] Bump reqwest from 0.11.4 to 0.11.9 in /src/rust/engine ([#14135](#14135)) * [internal] Further tweak dependabot config ([#14132](#14132)) * [internal] python: use immutable_input_digests for protobuf codegen ([#13885](#13885)) * [internal] python: use immutable_input_digests for protobuf codegen ([#13885](#13885)) * [internal] No need for two f-strings/two strings. ([#14119](#14119)) * `LockfileMetadata` - Replace flaky `_header_dict()` mechanism with more robust `header_attrs` mechanism ([#14229](#14229))

[internal] Introduce new BuiltinGoal subsystem type.

f2f29ba

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]

kaos requested a review from stuhood December 27, 2021 09:50

kaos commented Dec 27, 2021

View reviewed changes

Avoid computing scope options for unknown goals.

c521fa3

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

support showing help also for built in goals.

0dc6717

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

stuhood reviewed Jan 5, 2022

View reviewed changes

kaos added 5 commits January 6, 2022 16:01

Merge branch 'main' into builtin_goal

2eb707f

move BuiltinGoal to pants.goal.builtin_goal and registration to pants…

2c9cfb2

….goal.builtins

pass all remaining args unparsed to builtin goal.

bcaa33f

cleanup

422ad60

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

remove commented tests

c727f1f

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

kaos commented Jan 6, 2022

View reviewed changes

Eric-Arellano approved these changes Jan 6, 2022

View reviewed changes

place magic names in "constants".

5371f65

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

kaos added 2 commits January 11, 2022 10:53

Merge branch 'main' into builtin_goal

91fe691

Circle back one step, to again parse all options also for builtin goals.

747e383

kaos commented Jan 11, 2022

View reviewed changes

stuhood approved these changes Jan 11, 2022

View reviewed changes

kaos merged commit 0238387 into pantsbuild:main Jan 11, 2022

illicitonion mentioned this pull request Jan 22, 2022

Prep for 2.10.0.dev2 #14236

Merged

stuhood mentioned this pull request Feb 3, 2022

Add a goal to introspect and garbage collect caches. #11167

Open

4 tasks

kaos deleted the builtin_goal branch November 24, 2022 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[internal] Introduce new `BuiltinGoal` subsystem type. #13991

[internal] Introduce new `BuiltinGoal` subsystem type. #13991

kaos commented Dec 27, 2021 •

edited

Loading

kaos left a comment

kaos Dec 27, 2021

kaos Dec 27, 2021

kaos Dec 27, 2021

kaos Dec 27, 2021

kaos commented Dec 27, 2021

stuhood left a comment

stuhood Jan 5, 2022

kaos left a comment

kaos Jan 6, 2022

Eric-Arellano left a comment

kaos commented Jan 6, 2022

kaos commented Jan 7, 2022 •

edited

Loading

Eric-Arellano commented Jan 7, 2022

kaos commented Jan 10, 2022

stuhood commented Jan 10, 2022 •

edited

Loading

kaos commented Jan 11, 2022

kaos Jan 11, 2022

stuhood left a comment

[internal] Introduce new BuiltinGoal subsystem type. #13991

[internal] Introduce new BuiltinGoal subsystem type. #13991

Conversation

kaos commented Dec 27, 2021 • edited Loading

kaos left a comment

Choose a reason for hiding this comment

kaos Dec 27, 2021

Choose a reason for hiding this comment

kaos Dec 27, 2021

Choose a reason for hiding this comment

kaos Dec 27, 2021

Choose a reason for hiding this comment

kaos Dec 27, 2021

Choose a reason for hiding this comment

kaos commented Dec 27, 2021

stuhood left a comment

Choose a reason for hiding this comment

stuhood Jan 5, 2022

Choose a reason for hiding this comment

kaos left a comment

Choose a reason for hiding this comment

kaos Jan 6, 2022

Choose a reason for hiding this comment

Eric-Arellano left a comment

Choose a reason for hiding this comment

kaos commented Jan 6, 2022

kaos commented Jan 7, 2022 • edited Loading

Eric-Arellano commented Jan 7, 2022

kaos commented Jan 10, 2022

stuhood commented Jan 10, 2022 • edited Loading

kaos commented Jan 11, 2022

kaos Jan 11, 2022

Choose a reason for hiding this comment

stuhood left a comment

Choose a reason for hiding this comment

[internal] Introduce new `BuiltinGoal` subsystem type. #13991

[internal] Introduce new `BuiltinGoal` subsystem type. #13991

kaos commented Dec 27, 2021 •

edited

Loading

kaos commented Jan 7, 2022 •

edited

Loading

stuhood commented Jan 10, 2022 •

edited

Loading