-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal] Make generate-lockfiles
goal generic
#14122
[internal] Make generate-lockfiles
goal generic
#14122
Commits on Jan 7, 2022
-
Rename
PythonToolLockfileSentinel
toToolLockfileSentinel
and `Py……thonLockfile` to `Lockfile` These will be common types used across multiple languages like Python and Java. # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels] # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
Configuration menu - View commit details
-
Copy full SHA for 112f665 - Browse repository at this point
Copy the full SHA 112f665View commit details -
Add
LockfileRequest
union base to make lockfile generation genericThis also uses `WrappedLockfileRequest` so that we can make our tool lockfile code completely generic. We now have a way to dynamically compute which tools to generate lockfiles for, regardless of language. The only thing not yet generic is user lockfiles. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for d6c3af8 - Browse repository at this point
Copy the full SHA d6c3af8View commit details -
Move some lockfile helpers to
core/goals/generate_lockfiles.py
No changes made. Just moved around. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 73458a5 - Browse repository at this point
Copy the full SHA 73458a5View commit details -
Use a rule for warning about PythonRepos
This allows us to move that Python specific functionality out of the `generate-lockfiles` goal. We use a `@rule` so that the warning doesn't render more than one time. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 8c1e237 - Browse repository at this point
Copy the full SHA 8c1e237View commit details
Commits on Jan 8, 2022
-
This is pretty involved. We need to first use a union to discover all "known" resolves per language. We then need another union to convert all _requested_ resolves for that language into concrete LockfileRequest subclasses # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 3d66d35 - Browse repository at this point
Copy the full SHA 3d66d35View commit details -
Move
generate-lockfiles
goal tocore/goals
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 9790b27 - Browse repository at this point
Copy the full SHA 9790b27View commit details
Commits on Jan 11, 2022
-
Re-export the Python lockfile
@rule
s from each backend that registe……rs a `ToolLockfileSentinel`. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for b577d11 - Browse repository at this point
Copy the full SHA b577d11View commit details