Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] Refactor consumption of JVM tool lockfiles #14239

Merged
merged 5 commits into from
Jan 24, 2022
Merged

[internal] Refactor consumption of JVM tool lockfiles #14239

merged 5 commits into from
Jan 24, 2022

Commits on Jan 24, 2022

  1. Rename MaterializedClasspath to ToolClasspath 

    The type is only being used to set up tools—whether those be external like Scalafmt or internal like our JVM parser. This rename makes that clear, which will allow us to start adding tool-specific functionality.

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    7afbe7f View commit details
    Browse the repository at this point in the history

  2. Embrace that ToolClasspathRequest is 1-per-tool 

    This is how we've been using it de facto, including in two rules where there are 2 tools used in the same process. This allows us to simplify callsites / remove verbosity

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    d8c159f View commit details
    Browse the repository at this point in the history

  3. Use the engine to read tool lockfiles, not open() 

    This is necessary to not break caching.

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a1cba1b View commit details
    Browse the repository at this point in the history

  4. Fix scalatest test 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    e766ae9 View commit details
    Browse the repository at this point in the history

  5. Fix some excessive newlines 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    d3d0a9c View commit details
    Browse the repository at this point in the history