[internal] Parse addresses using a generated parser #14346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-build-wheels] [ci skip-rust]
[ci skip-build-wheels]
stuhood
commented
Feb 3, 2022
Comment on lines
+34
to
+35
| peg::parser! { | ||
| grammar relative_address_parser() for str { |
There was a problem hiding this comment.
I was really impressed with how easy this crate was to use: good choice @jsirois!
There was a problem hiding this comment.
I love PEG's. (first and only placed I've used/seen them is in Lua, which I think is where they originated, from Mr Roberto I)
stuhood
force-pushed
the
stuhood/address-parser
branch
from
def99cc
to
8d5a4da
Compare
Eric-Arellano
approved these changes
Feb 3, 2022
Briefly... but I've been trying to bias away from adding more code to |
alonsodomin
pushed a commit
to alonsodomin/pants
that referenced
this pull request
Feb 25, 2022
…antsbuild#14485) This issue was introduced by pantsbuild#14346 [ci skip-rust]
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 3, 2022
…antsbuild#14485) This issue was introduced by pantsbuild#14346 [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Mar 30, 2022
#14347 added support for `Address` parameters, which are used via the `parametrize` builtin. But we had not yet added support for parsing parametrized addresses to CLI specs parsing. This change adds support for parsing parametrized addresses in CLI specs by generalizing the parser that was added in #14346 to support parsing the additional syntax required for CLI specs (`!` ignores and `:`/`::` wildcards), and then using the same parser (with different validation) for both `Address` and `Specs` parsing. Fixes #14521. [ci skip-build-wheels]
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 30, 2022
…sbuild#14949) pantsbuild#14347 added support for `Address` parameters, which are used via the `parametrize` builtin. But we had not yet added support for parsing parametrized addresses to CLI specs parsing. This change adds support for parsing parametrized addresses in CLI specs by generalizing the parser that was added in pantsbuild#14346 to support parsing the additional syntax required for CLI specs (`!` ignores and `:`/`::` wildcards), and then using the same parser (with different validation) for both `Address` and `Specs` parsing. Fixes pantsbuild#14521. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Mar 30, 2022
…rypick of #14949) (#14957) #14347 added support for `Address` parameters, which are used via the `parametrize` builtin. But we had not yet added support for parsing parametrized addresses to CLI specs parsing. This change adds support for parsing parametrized addresses in CLI specs by generalizing the parser that was added in #14346 to support parsing the additional syntax required for CLI specs (`!` ignores and `:`/`::` wildcards), and then using the same parser (with different validation) for both `Address` and `Specs` parsing. Fixes #14521. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare to make the address syntax more complicated as part of #13882, move to parsing addresses using a generated
pegparser (using the same parser crate that @jsirois introduced in #11922).Additionally, simplify
Address.specandAddress.path_safe_specslightly by removing non-trivial early returns and reducing the total number of f-strings.[ci skip-build-wheels]