Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace compatible_resolves with resolve for JVM targets #14441

Merged

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Feb 11, 2022

As designed in #13882 (and elaborated on in #14420 in the context of Python), the parametrize builtin means that targets which want to support multiple resolves (or Scala versions) should use resolve=parametrize(..), so that a different target is created per resolve.

This change replaces the compatible_resolves field with resolve for the JVM. And in order to allow the resolve field to be parametrized, it also moves it from the core_fields of JVM target generators (which cannot be parametrized) to the moved_fields.

…an optionally be used with `parametrize`).

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
…solve_for_target` fallible.

[ci skip-rust]
[ci skip-build-wheels]
@stuhood
Copy link
Member Author

stuhood commented Feb 11, 2022

Commits are useful to review independently.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah

@stuhood stuhood enabled auto-merge (squash) February 11, 2022 01:07
@stuhood stuhood merged commit 3c3d9d8 into pantsbuild:main Feb 11, 2022
@stuhood stuhood deleted the stuhood/remove-jvm-compatible-resolves branch February 11, 2022 02:04
stuhood added a commit that referenced this pull request Feb 17, 2022
…ked set of targets. (#14525)

#14441 removed the distinction between root and inner targets from resolve computation, but the error message continued to only report the root targets.

Report all checked targets instead.

[ci skip-rust]
[ci skip-build-wheels]
alonsodomin pushed a commit to alonsodomin/pants that referenced this pull request Feb 25, 2022
…ked set of targets. (pantsbuild#14525)

pantsbuild#14441 removed the distinction between root and inner targets from resolve computation, but the error message continued to only report the root targets.

Report all checked targets instead.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants