Replace compatible_resolves with resolve for JVM targets
#14441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an optionally be used with `parametrize`). # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
…solve_for_target` fallible. [ci skip-rust] [ci skip-build-wheels]
|
Commits are useful to review independently. |
This was referenced Feb 11, 2022
alonsodomin
pushed a commit
to alonsodomin/pants
that referenced
this pull request
Feb 25, 2022
…ked set of targets. (pantsbuild#14525) pantsbuild#14441 removed the distinction between root and inner targets from resolve computation, but the error message continued to only report the root targets. Report all checked targets instead. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As designed in #13882 (and elaborated on in #14420 in the context of Python), the
parametrizebuiltin means that targets which want to support multiple resolves (or Scala versions) should useresolve=parametrize(..), so that a different target is created per resolve.This change replaces the
compatible_resolvesfield withresolvefor the JVM. And in order to allow theresolvefield to beparametrized, it also moves it from thecore_fieldsof JVM target generators (which cannot beparametrized) to themoved_fields.