Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] Softwrapping global options #14853

Merged
merged 2 commits into from
Mar 21, 2022
Merged

[internal] Softwrapping global options #14853

merged 2 commits into from
Mar 21, 2022

Conversation

thejcannon
Copy link
Member

This one is in it's own PR :)

[ci skip-rust]
[ci skip-build-wheels]

@thejcannon
global options
6c2b42a 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@thejcannon
fix quot
1fbb4d5 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@thejcannon
Copy link
Member Author

Pretty pleased with this one:

joshuacannon@CEPHANDRIUS:~/work/pants$ diff -u -r /tmp/pants_docs_main /tmp/pants_docs
diff -u -r /tmp/pants_docs_main/help/option/GLOBAL.md /tmp/pants_docs/help/option/GLOBAL.md
--- /tmp/pants_docs_main/help/option/GLOBAL.md  2022-03-19 06:27:33.208978293 -0500
+++ /tmp/pants_docs/help/option/GLOBAL.md       2022-03-19 15:31:55.744440902 -0500
@@ -333,7 +333,6 @@
         "DEPRECATED: option 'config' in scope 'flake8' will be removed",
         '$regex$:No files\s*'
     ]
-
 </div>
 <br>
 
@@ -664,7 +663,7 @@
 
 The number of threads to keep active and ready to execute `@rule` logic (see also: `--rule-threads-max`).
 
-Values less than 2 are not currently supported. 
+Values less than 2 are not currently supported.
 
 This value is independent of the number of processes that may be spawned in parallel locally (controlled by `--process-execution-local-parallelism`).
 </div>

@thejcannon thejcannon requested a review from kaos March 19, 2022 20:32
kaos
kaos approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm :)

@thejcannon thejcannon added the category:internal CI, fixes for not-yet-released features, etc. label Mar 21, 2022
@thejcannon thejcannon merged commit 180b58e into pantsbuild:main Mar 21, 2022
@thejcannon thejcannon deleted the softwrapglobal branch March 21, 2022 13:22
@benjyw benjyw mentioned this pull request Mar 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@kaos kaos kaos approved these changes

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thejcannon @stuhood @kaos