Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] BSP: update compile rules to work again #14906

Merged
merged 1 commit into from
Mar 25, 2022
Merged

[internal] BSP: update compile rules to work again #14906

merged 1 commit into from
Mar 25, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Mar 24, 2022

The BSP compile rules bit-rotted while some other refactoring was being done this week. Update the compile rules to work again.

[ci skip-rust]

[ci skip-build-wheels]

get BSP compile working again
6607700 
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas added the category:internal CI, fixes for not-yet-released features, etc. label Mar 24, 2022
@tdyas tdyas merged commit 2da7911 into pantsbuild:main Mar 25, 2022
@tdyas tdyas deleted the bsp_fix_compile branch March 25, 2022 00:27
@benjyw benjyw mentioned this pull request Mar 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@chrisjrn chrisjrn Awaiting requested review from chrisjrn

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdyas @Eric-Arellano