Refactor prior_formatter_result and its usage
#14987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
thejcannon
added
the
category:internal
thejcannon
commented
Apr 4, 2022
| @@ -49,7 +48,6 @@ class GoogleJavaFormatToolLockfileSentinel(GenerateToolLockfileSentinel): | |||
| @dataclass(frozen=True) | |||
| class Setup: | |||
There was a problem hiding this comment.
Trying to elide this class with the JvmProcess directly causes a graph error :|
There was a problem hiding this comment.
Sorry for the trouble there. If you want to open a ticket about that linked to #11269 feel free.
thejcannon
changed the title
prior_formatter_result and it's usage prior_formatter_result and its usage
stuhood
approved these changes
Apr 4, 2022
src/python/pants/backend/codegen/protobuf/lint/buf/format_rules.py
Outdated
Show resolved
Hide resolved
| @@ -49,7 +48,6 @@ class GoogleJavaFormatToolLockfileSentinel(GenerateToolLockfileSentinel): | |||
| @dataclass(frozen=True) | |||
| class Setup: | |||
There was a problem hiding this comment.
Sorry for the trouble there. If you want to open a ticket about that linked to #11269 feel free.
Eric-Arellano
approved these changes
Apr 4, 2022
thejcannon
added
category:plugin api change
and removed
category:internal
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
thejcannon
changed the title
prior_formatter_result and its usage prior_formatter_result and its usage
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Jun 28, 2022
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is renaming
prior_formatter_resultto besnapshot, and removing| Nonefrom its type.Then call-sites must be refactored to remove the
if Noneconditional since its neverNone. Which then leads to removing thesource_filesGet.Also, now
original_snapshotin most formatter'sSetupis superfluous. So it can be replaced by theProcessit contains. More refactoring.Lastly, I added
FmtResult.createsince therequest/resultcontain most of the requisite info.[ci skip-rust]
[ci skip-build-wheels]