Do not use a repository-PEX if a PEX has platforms specified #15031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
commented
Apr 6, 2022
| "enable_resolves", | ||
| [ | ||
| False, | ||
| pytest.param(True, marks=pytest.mark.xfail(reason="#14991 causes this to fail in 2.11.x")), |
There was a problem hiding this comment.
This test (which asserts that we don't use the entire lockfile) cannot pass on main due to #14991, but I've validated that it passes on 2.10.x, and will remove the xfail while picking it.
src/python/pants/backend/python/util_rules/pex_from_targets_test.py
Outdated
Show resolved
Hide resolved
Eric-Arellano
approved these changes
Apr 6, 2022
src/python/pants/backend/python/util_rules/pex_from_targets_test.py
Outdated
Show resolved
Hide resolved
[ci skip-build-wheels] [ci skip-rust]
stuhood
force-pushed
the
stuhood/do-not-use-repository-pex-if-platforms
branch
from
2a0f650
to
ff263be
Compare
Comment on lines
+180
to
+182
| constraints_strings = FrozenOrderedSet( | ||
| str(req) for req in parse_requirements_file(lock_string, rel_path=lockfile_path) | ||
| ) |
There was a problem hiding this comment.
I don't think that this will handle hash correctly?
There was a problem hiding this comment.
Indeed: added another commit to improve parsing.
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/do-not-use-repository-pex-if-platforms
branch
from
ff263be
to
2f6f8e6
Compare
|
Parsing algorithm looks good. Thanks for adding tests! |
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Apr 7, 2022
…ild#15031) [ci skip-rust] [ci skip-build-wheels]
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Apr 7, 2022
…ild#15031) pantsbuild#14995 shows that pantsbuild#12222 re-broke for the `enable_resolves` case, since the fix for the issue was only checking the `resolve_all_constraints` field. Fixes pantsbuild#14995. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14995 shows that #12222 re-broke for the
enable_resolvescase, since the fix for the issue was only checking theresolve_all_constraintsfield. Fixes #14995.