Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve help and error message for [python-infer].unowned_dependency_behavior #15334

Merged
merged 8 commits into from
May 10, 2022
Merged

Improve help and error message for [python-infer].unowned_dependency_behavior #15334

merged 8 commits into from
May 10, 2022

Commits on May 4, 2022

  1. Improve help and error message for `[python-infer].unowned_dependen… 

    …cy_behavior`

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
    @Eric-Arellano
    Eric-Arellano committed May 4, 2022
    Configuration menu
    Copy the full SHA
    ef23c0e View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Merge branch 'main' of github.com:pantsbuild/pants into improve-unown… 

    …ed-deps-err-msg
    @Eric-Arellano
    Eric-Arellano committed May 5, 2022
    Configuration menu
    Copy the full SHA
    b6fa274 View commit details
    Browse the repository at this point in the history

  2. Round 2 of improvement

    @Eric-Arellano
    Eric-Arellano committed May 5, 2022
    Configuration menu
    Copy the full SHA
    2c5cb86 View commit details
    Browse the repository at this point in the history

  3. Good Flake8! Don't hardcode ./pants 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed May 5, 2022
    Configuration menu
    Copy the full SHA
    0737413 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Refer to docsite rather than long message 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed May 9, 2022
    Configuration menu
    Copy the full SHA
    b37a78f View commit details
    Browse the repository at this point in the history

  2. Add detection of imports from other resolves 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed May 9, 2022
    Configuration menu
    Copy the full SHA
    cb279d9 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Fix bug + type hints + add new tests! 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7e4c39d View commit details
    Browse the repository at this point in the history

  2. Improve the test 

    This caught a bug when the target has multiple resolves. I want to make sure we handle when a target has a single resolve

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed May 10, 2022
    Configuration menu
    Copy the full SHA
    8b91658 View commit details
    Browse the repository at this point in the history