Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "named args explanation" to other relevant parametrize error messages. #15362

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented May 6, 2022

For non-string arguments, the way to use parametrize is still via named arguments, but we were only including that explanation on the "illegal characters in string" case.

[ci skip-rust]
[ci skip-build-wheels]

… error message.

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood added needs-cherrypick category:bugfix Bug fixes for released features labels May 6, 2022
@stuhood stuhood added this to the 2.11.x milestone May 6, 2022
@stuhood stuhood requested a review from Eric-Arellano May 6, 2022 17:52
@stuhood stuhood enabled auto-merge (squash) May 6, 2022 17:56
@stuhood stuhood changed the title Add the "named args explanation" to the non-string postional argument error message. Add the "named args explanation" to other relevant parametrize error messages. May 6, 2022
@stuhood stuhood merged commit 176ec9a into pantsbuild:main May 6, 2022
@stuhood stuhood deleted the stuhood/parametrize-named-args-for-type-mismatch branch May 6, 2022 19:18
stuhood added a commit to stuhood/pants that referenced this pull request May 6, 2022
…r messages. (pantsbuild#15362)

For non-string arguments, the way to use `parametrize` is still via named arguments, but we were only including that explanation on the "illegal characters in string" case.

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this pull request May 6, 2022
…r messages. (pantsbuild#15362)

For non-string arguments, the way to use `parametrize` is still via named arguments, but we were only including that explanation on the "illegal characters in string" case.

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit that referenced this pull request May 6, 2022
…r messages. (Cherry-pick of #15362) (#15370)

For non-string arguments, the way to use `parametrize` is still via named arguments, but we were only including that explanation on the "illegal characters in string" case.

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit that referenced this pull request May 6, 2022
…r messages. (Cherry-pick of #15362) (#15369)

For non-string arguments, the way to use `parametrize` is still via named arguments, but we were only including that explanation on the "illegal characters in string" case.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants