Significantly reduce the dependencies of RuleRunner
#15631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
added
the
category:internal
|
While this could potentially be a candidate for #13393, the exact rule that we would use here isn't clear to me. |
[ci skip-rust]
stuhood
force-pushed
the
stuhood/narrow-rule-runner-deps
branch
from
1477db9
to
6b30592
Compare
Eric-Arellano
approved these changes
May 24, 2022
thejcannon
reviewed
May 25, 2022
| @@ -111,6 +111,7 @@ def load_build_configuration_from_source( | |||
| :raises: :class:``pants.base.exceptions.BuildConfigurationError`` if there is a problem loading | |||
| the build configuration. | |||
| """ | |||
| # NB: Backends added here must be explicit dependencies of this module. | |||
| backend_packages = FrozenOrderedSet(["pants.core", "pants.backend.project_info", *backends]) | |||
There was a problem hiding this comment.
Would string import inference work here? 🤔
There was a problem hiding this comment.
Not out of the box I don't think... the actual underlying modules are pants.core.register and pants.backend.project_info.register.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire
initpackage depended on thepluginstarget, but the underlying reason for that dependency was to include all plugins in published distributions and PEXes... which are defined in thebinpackage. As a side-effect, allRuleRunnertests depended on all plugins, which significantly increased the size of their cache keys.Before:
After:
Moral of the story: explicit deps are dangerous...?
[ci skip-rust]