Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala: mark an object that extends another type as recursive #15865

Merged
merged 4 commits into from
Jun 20, 2022

Conversation

somdoron
Copy link
Contributor

Scala Parser cannot figure out the provided types of an object that extends another type. This PR solves this by marking the object as recursive.

The following example won't compile with Pants at the moment:

File A:

object A {
  def a(x: Int): Int = ???
}

File B:

import A

object B extends A {
  
}

File Main:

import B.a

def main() = println(a(5))

@tdyas tdyas added the category:internal CI, fixes for not-yet-released features, etc. label Jun 17, 2022
@tdyas tdyas requested review from tdyas and stuhood June 17, 2022 19:09
@tdyas
Copy link
Contributor

tdyas commented Jun 17, 2022

There is a merge conflict.

@somdoron
Copy link
Contributor Author

@tdyas merge conflict fixed and I've added a test for the example in the description.

@somdoron somdoron requested a review from tdyas June 19, 2022 11:32
@tdyas
Copy link
Contributor

tdyas commented Jun 20, 2022

@somdoron: Is this ready to be merged?

@somdoron
Copy link
Contributor Author

Yes, ready to be merged.

Can this also be cherry picked for 2.13?

@tdyas
Copy link
Contributor

tdyas commented Jun 20, 2022

Can this also be cherry picked for 2.13?

Yes. I'll mark it to be cherry picked.

@tdyas tdyas added category:bugfix Bug fixes for released features and removed category:internal CI, fixes for not-yet-released features, etc. labels Jun 20, 2022
@tdyas tdyas merged commit e7f1da0 into pantsbuild:main Jun 20, 2022
@tdyas tdyas added this to the 2.13.x milestone Jun 20, 2022
tdyas pushed a commit to tdyas/pants that referenced this pull request Jun 22, 2022
…ild#15865)

Scala Parser cannot figure out the provided types of an object that extends another type. This PR solves this by marking the object as recursive.

The following example won't compile with Pants at the moment:

File A:
```
object A {
  def a(x: Int): Int = ???
}
```

File B:
```
import A

object B extends A {
  
}
```
File Main:
```
import B.a

def main() = println(a(5))
```
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
tdyas pushed a commit that referenced this pull request Jun 22, 2022
…pick of #15865) (#15891)

Scala Parser cannot figure out the provided types of an object that extends another type. This PR solves this by marking the object as recursive.

The following example won't compile with Pants at the moment:

File A:
```
object A {
  def a(x: Int): Int = ???
}
```

File B:
```
import A

object B extends A {
  
}
```
File Main:
```
import B.a

def main() = println(a(5))
```
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants