Scala: mark an object that extends another type as recursive #15865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
reviewed
Jun 17, 2022
src/python/pants/backend/scala/dependency_inference/scala_parser_test.py
Show resolved
Hide resolved
|
There is a merge conflict. |
|
@tdyas merge conflict fixed and I've added a test for the example in the description. |
tdyas
approved these changes
Jun 20, 2022
|
@somdoron: Is this ready to be merged? |
|
Yes, ready to be merged. Can this also be cherry picked for 2.13? |
Yes. I'll mark it to be cherry picked. |
tdyas
added
category:bugfix
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
Jun 22, 2022
…ild#15865) Scala Parser cannot figure out the provided types of an object that extends another type. This PR solves this by marking the object as recursive. The following example won't compile with Pants at the moment: File A: ``` object A { def a(x: Int): Int = ??? } ``` File B: ``` import A object B extends A { } ``` File Main: ``` import B.a def main() = println(a(5)) ``` # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
tdyas
pushed a commit
that referenced
this pull request
Jun 22, 2022
…pick of #15865) (#15891) Scala Parser cannot figure out the provided types of an object that extends another type. This PR solves this by marking the object as recursive. The following example won't compile with Pants at the moment: File A: ``` object A { def a(x: Int): Int = ??? } ``` File B: ``` import A object B extends A { } ``` File Main: ``` import B.a def main() = println(a(5)) ``` # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala Parser cannot figure out the provided types of an object that extends another type. This PR solves this by marking the object as recursive.
The following example won't compile with Pants at the moment:
File A:
File B:
File Main: