Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JVM memory controls to bound the process pool size to less than the process parallelism (Cherry-pick of #15903) #15917

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Jun 24, 2022

As described in #15808, the assumption that the nailgun pool runs under an appropriately sized semaphore has not been true since #15224, and results in an error when memory controls cause the pool size to be smaller than the process parallelism.

To resolve that, we add an additional semaphore (and blocked workunit) to pool acquisition.

Fixes #15808.

[ci skip-build-wheels]

… the process parallelism (pantsbuild#15903)

As described in pantsbuild#15808, the assumption that the nailgun pool runs under an appropriately sized semaphore has not been true since pantsbuild#15224, and results in an error when memory controls cause the pool size to be smaller than the process parallelism.

To resolve that, we add an additional semaphore (and blocked workunit) to pool acquisition.

Fixes pantsbuild#15808.

[ci skip-build-wheels]
@stuhood stuhood added the category:bugfix Bug fixes for released features label Jun 24, 2022
@stuhood stuhood merged commit bbba6f9 into pantsbuild:2.13.x Jun 24, 2022
@stuhood stuhood deleted the cherry-pick-15903-to-2.13.x branch June 24, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants