Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --excluded-target-regexp, --files-not-found-behavior, and --owners-not-found-behavior global options #15929

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Remove deprecated --excluded-target-regexp, --files-not-found-behavior, and --owners-not-found-behavior global options #15929

merged 5 commits into from
Jun 24, 2022

Conversation

Eric-Arellano
Copy link
Contributor

In the process, this closes #15802.

Before:

❯ hyperfine -w 1 -r 5 './pants --no-pantsd --no-buildsense-enable --no-anonymous-telemetry-enabled --spec-files=tgts.txt list'
Benchmark 1: ./pants --no-pantsd --no-buildsense-enable --no-anonymous-telemetry-enabled --spec-files=tgts.txt list
  Time (mean ± σ):      4.255 s ±  0.034 s    [User: 3.906 s, System: 0.545 s]
  Range (min … max):    4.223 s …  4.314 s    5 runs

After:

❯ hyperfine -w 1 -r 5 './pants --no-pantsd --no-buildsense-enable --no-anonymous-telemetry-enabled --spec-files=tgts.txt list'
Benchmark 1: ./pants --no-pantsd --no-buildsense-enable --no-anonymous-telemetry-enabled --spec-files=tgts.txt list
  Time (mean ± σ):      3.837 s ±  0.271 s    [User: 3.315 s, System: 0.452 s]
  Range (min … max):    3.645 s …  4.302 s    5 runs

@Eric-Arellano
Remove --exclude-target-regexp
ee86bf6 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
@Eric-Arellano
Remove --files-not-found-behavior
7ac6508 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano
Remove --owners-not-found-behavior and fix performance issue
37e070f 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
stuhood
stuhood approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@Eric-Arellano Eric-Arellano enabled auto-merge (squash) June 24, 2022 17:08
@Eric-Arellano
Fix fmt
8175dfc 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano mentioned this pull request Jun 24, 2022
Merged
@Eric-Arellano
Fix tests
c1da34b 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano merged commit 6ac5583 into pantsbuild:main Jun 24, 2022
@Eric-Arellano Eric-Arellano deleted the rm-214-deps branch June 24, 2022 19:03
Eric-Arellano added a commit that referenced this pull request Jun 24, 2022
@Eric-Arellano
Improve performance of file arguments when `--owners-not-found-behavi…
7ab6b22 
…or` not used (#15931)

Fixes #15802 for 2.13 branch.

This will become the only code path in 2.14+, thanks to removing `--owners-not-found-behavior`. See #15929.

[ci skip-rust]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

Assignees
No one assigned
Labels
category:user api change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of Owners lookups is proportional to number of CLI specs
2 participants
@Eric-Arellano @stuhood