-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate not setting tailor_pex_binary_targets
explictly
#15962
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this is a good idea.
My only concern is the noise for new users. Maybe we update python-backend.md
where we say to activate the Python backend and have them automatically set this value? It feels wrong to put this in something more generic like our onboarding guide, as it only works if you are using Python.
It's only an issue for newcomers activating python backend and running |
Which we don't want because it is a bad default. And they will be confused what the warning is. I think the solution is to update the |
[ci skip-rust] [ci skip-build-wheels]
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
[ci skip-rust] [ci skip-build-wheels]
…ld#15962) With pantsbuild#15849 the default for the `--tailor-pex-binary-targets` flag should naturally be `False`, so this begins the path to that. [ci skip-rust] [ci skip-build-wheels]
With #15849 the default for the
--tailor-pex-binary-targets
flag should naturally beFalse
, so this begins the path to that.[ci skip-rust]
[ci skip-build-wheels]