Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate not setting tailor_pex_binary_targets explictly #15962

Merged
merged 5 commits into from
Jul 1, 2022

Conversation

thejcannon
Copy link
Member

With #15849 the default for the --tailor-pex-binary-targets flag should naturally be False, so this begins the path to that.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a good idea.

My only concern is the noise for new users. Maybe we update python-backend.md where we say to activate the Python backend and have them automatically set this value? It feels wrong to put this in something more generic like our onboarding guide, as it only works if you are using Python.

@thejcannon
Copy link
Member Author

It's only an issue for newcomers activating python backend and running tailor and tailor would add a target, right?

@Eric-Arellano
Copy link
Contributor

It's only an issue for newcomers activating python backend and running tailor and tailor would add a target, right?

Which we don't want because it is a bad default. And they will be confused what the warning is. I think the solution is to update the pants.toml snippet in python-backend.md.

[ci skip-rust]

[ci skip-build-wheels]
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@Eric-Arellano Eric-Arellano merged commit 7d0f484 into pantsbuild:main Jul 1, 2022
@thejcannon thejcannon deleted the fliptailor branch July 1, 2022 10:43
thejcannon added a commit to thejcannon/pants that referenced this pull request Jul 1, 2022
…ld#15962)

With pantsbuild#15849 the default for the `--tailor-pex-binary-targets` flag should naturally be `False`, so this begins the path to that.

[ci skip-rust]
[ci skip-build-wheels]
Eric-Arellano pushed a commit that referenced this pull request Jul 1, 2022
…ick of #15962) (#16023)

With #15849 the default for the `--tailor-pex-binary-targets` flag should naturally be `False`, so this begins the path to that.

[ci skip-rust]
[ci skip-build-wheels]
thejcannon added a commit that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants