Backtrack through calls from @rules
to synchronous engine methods (Cherry-pick of #15979)
#16003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #15954, backtracking doesn't currently work when a synchronous method like
Workspace.write_digests
is the source of aMissingDigest
error. This was due to a TODO left behind in #15761, where we did not propagate theFailure
type "through"@rule
bodies.To fix this, we add a conversion from
Failure
toPrErr
which wraps in a well known exception type, and then look for that type when converting back fromPyErr
toFailure
.Fixes #15954.