Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] add compile test for Apache Thrift Java codegen #16169

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Jul 13, 2022

Add a compilation test for generated code from the Apache Thrift Java codegen backend.

[ci skip-rust]

@tdyas tdyas added the category:internal CI, fixes for not-yet-released features, etc. label Jul 13, 2022
@tdyas tdyas requested review from stuhood and chrisjrn July 13, 2022 20:01
*javac_rules(),
*java_dep_inf_rules(),
*testutil.rules(),
*scalac_rules(), # TODO: Figure out why this needed to avoid rule graph errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... nothing jumps out at me either.

@tdyas tdyas merged commit 8b17a13 into pantsbuild:main Jul 13, 2022
@tdyas tdyas deleted the java_apache_thrift_compile_test branch July 13, 2022 21:26
@stuhood stuhood mentioned this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants