Remove PANTS(C)_PROFILE in favor of recommending py-spy.
#16226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added
the
category:internal
|
+1 from me! |
Merged
jyggen
pushed a commit
to jyggen/pants
that referenced
this pull request
Jul 27, 2022
…ild#16226) `py-spy` is superior to `cProfile` based profiling, and is already [documented](https://github.com/pantsbuild/pants/blob/99e2130deec1ad87a417cdc997a5fecd3f458965/docs/markdown/Contributions/development/contributions-debugging.md#profiling-with-py-spy). Remove the `PANTS(C)_PROFILE` environment variables which used to trigger profiling (which are _not_ documented). Fixes pantsbuild#3431. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py-spyis superior tocProfilebased profiling, and is already documented. Remove thePANTS(C)_PROFILEenvironment variables which used to trigger profiling (which are not documented).Fixes #3431.
[ci skip-rust]
[ci skip-build-wheels]