Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PANTS(C)_PROFILE in favor of recommending py-spy. #16226

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Jul 19, 2022

py-spy is superior to cProfile based profiling, and is already documented. Remove the PANTS(C)_PROFILE environment variables which used to trigger profiling (which are not documented).

Fixes #3431.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood added the category:internal CI, fixes for not-yet-released features, etc. label Jul 19, 2022
@stuhood stuhood enabled auto-merge (squash) July 19, 2022 17:32
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@thejcannon
Copy link
Member

+1 from me!

@stuhood stuhood merged commit b0b15e1 into pantsbuild:main Jul 19, 2022
@stuhood stuhood mentioned this pull request Jul 22, 2022
jyggen pushed a commit to jyggen/pants that referenced this pull request Jul 27, 2022
…ild#16226)

`py-spy` is superior to `cProfile` based profiling, and is already [documented](https://github.com/pantsbuild/pants/blob/99e2130deec1ad87a417cdc997a5fecd3f458965/docs/markdown/Contributions/development/contributions-debugging.md#profiling-with-py-spy). Remove the `PANTS(C)_PROFILE` environment variables which used to trigger profiling (which are _not_ documented).

Fixes pantsbuild#3431.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PANTS_PROFILE
3 participants