Make DependencyKey a concrete type
#16628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-build-wheels]
stuhood
added
the
category:internal
Eric-Arellano
approved these changes
Aug 24, 2022
tdyas
reviewed
Aug 24, 2022
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
approved these changes
Aug 24, 2022
Merged
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
As described in pantsbuild#12946 (comment), `DependencyKey` being abstract makes changing the number of provided parameters to a `Get` more challenging than necessary. To prepare for pantsbuild#12946 and pantsbuild#7490, this change converts `DependencyKey` to a concrete type containing a `smallvec` of provided parameters. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #12946 (comment),
DependencyKeybeing abstract makes changing the number of provided parameters to aGetmore challenging than necessary.To prepare for #12946 and #7490, this change converts
DependencyKeyto a concrete type containing asmallvecof provided parameters.[ci skip-build-wheels]