Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DependencyKey a concrete type #16628

Merged
merged 4 commits into from
Aug 24, 2022

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Aug 24, 2022

As described in #12946 (comment), DependencyKey being abstract makes changing the number of provided parameters to a Get more challenging than necessary.

To prepare for #12946 and #7490, this change converts DependencyKey to a concrete type containing a smallvec of provided parameters.

[ci skip-build-wheels]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood added the category:internal CI, fixes for not-yet-released features, etc. label Aug 24, 2022
@stuhood stuhood enabled auto-merge (squash) August 24, 2022 16:03
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup. I'm glad to see selectors.rs be deleted :)

src/rust/engine/rule_graph/src/rules.rs Show resolved Hide resolved
src/rust/engine/src/nodes.rs Show resolved Hide resolved
@stuhood stuhood disabled auto-merge August 24, 2022 16:38
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood enabled auto-merge (squash) August 24, 2022 16:47
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood merged commit 41edce6 into pantsbuild:main Aug 24, 2022
@stuhood stuhood deleted the stuhood/concrete-dependency-key branch August 24, 2022 19:29
cczona pushed a commit to cczona/pants that referenced this pull request Sep 1, 2022
As described in pantsbuild#12946 (comment), `DependencyKey` being abstract makes changing the number of provided parameters to a `Get` more challenging than necessary.

To prepare for pantsbuild#12946 and pantsbuild#7490, this change converts `DependencyKey` to a concrete type containing a `smallvec` of provided parameters.

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants