Add support for passing multiple input params to a @rule Get
#16668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-build-wheels] [ci skip-rust]
[ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/get-multiple-provided-params
branch
from
d100c7b
to
84c13b0
Compare
…ng them to Python. [ci skip-build-wheels]
[ci skip-build-wheels]
… they are not yet parsed. [ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/get-multiple-provided-params
branch
from
84c13b0
to
4854d1e
Compare
|
Commits are useful to review independently. |
tdyas
approved these changes
Aug 26, 2022
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Aug 27, 2022
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Aug 27, 2022
Merged
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…tsbuild#16668) In order to support differentiating `@rule` subgraphs for different "environments" as described in the design doc for pantsbuild#13682, `@rules` need to be able inject more than one parameter into any particular subgraph. As a concrete example: the `test` `@rules` need to be able to request "a `TestResult` for this `FieldSet` in this `Environment`". This change adds support for multiple parameters to a `Get`, such that that use case would be spelled out as: ```python test_result = await Get(TestResult, {field_set: FieldSet, environment: Environment}) ``` Fixes pantsbuild#7490. [ci skip-build-wheels]
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
[ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Sep 12, 2022
Follow up to #16668. [ci skip-rust]
kaos
added a commit
to kaos/pants
that referenced
this pull request
Dec 6, 2022
It became stale with pantsbuild#16668.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support differentiating
@rulesubgraphs for different "environments" as described in the design doc for #13682,@rulesneed to be able inject more than one parameter into any particular subgraph.As a concrete example: the
test@rulesneed to be able to request "aTestResultfor thisFieldSetin thisEnvironment". This change adds support for multiple parameters to aGet, such that that use case would be spelled out as:Fixes #7490.
[ci skip-build-wheels]