Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for ./pants help _underscored_target #16834

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

chrisjrn
Copy link
Contributor

This allows users to request help for undocumented targets, but it does not appear in ./pants help targets

(while still suppressing `_underscored target` from `./pants help targets` output)

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]

(cherry picked from commit 9380196acdb07859533d86d169556f8571ca0018)
@chrisjrn chrisjrn requested review from stuhood and Eric-Arellano and removed request for stuhood and Eric-Arellano September 12, 2022 20:18
@chrisjrn chrisjrn added category:new feature category:internal CI, fixes for not-yet-released features, etc. and removed category:new feature labels Sep 12, 2022
@chrisjrn chrisjrn marked this pull request as ready for review September 12, 2022 20:19
@chrisjrn
Copy link
Contributor Author

This is pre-work for #15057, because it's difficult to see the options defined on a target without it.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Christopher Neugebauer added 2 commits September 13, 2022 08:15
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@chrisjrn chrisjrn merged commit 68c2cf5 into pantsbuild:main Sep 13, 2022
@chrisjrn chrisjrn deleted the chrisjrn/help-for-hidden-targets branch September 13, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants