Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the timeout for the docker timeout test. #16864

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Sep 14, 2022

See #16855. The timeout is applied only after we have successfully opened an output stream from the process, so the hypothesis with this test is that the process just runs more slowly under docker, and needs longer to get to the point where it can render output.

Fixes #16855.

[ci skip-build-wheels]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood added the category:internal CI, fixes for not-yet-released features, etc. label Sep 14, 2022
@tdyas
Copy link
Contributor

tdyas commented Sep 14, 2022

so the hypothesis with this test is that the process just runs more slowly under docker, and needs longer to get to the point where it can render output.

Also, each test is spawning its own cached container since each test instantiates a separate instance of docker::CommandRunner. We could use a shared command runner for the tests to increase performance of the tests at the risk of coupling otherwise unrelated tests together.

@stuhood
Copy link
Member Author

stuhood commented Sep 14, 2022

Also, each test is spawning its own cached container since each test instantiates a separate instance of docker::CommandRunner.

That shouldn't impact the performance of the process once we've already attached (should it?), which is when the timeout comes into play.

@tdyas
Copy link
Contributor

tdyas commented Sep 14, 2022

That shouldn't impact the performance of the process once we've already attached (should it?), which is when the timeout comes into play.

Ah yeah, probably not then.

@Eric-Arellano Eric-Arellano merged commit 4142c53 into pantsbuild:main Sep 14, 2022
@stuhood stuhood deleted the stuhood/docker-timeout branch September 14, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Rust timeout test is flaky
3 participants