Prefactor `directory.rs` for symlink plumbing #16872

thejcannon · 2022-09-14T20:56:06Z

Prefactoring 2 things for the upcoming symlink support:

Splitting DigestTrie.files_and_directories into files and directories. The only place we used both was a __repr__, so perf likely isn't key
Changing DigestTrie.from_path_stats to use TypedPath (and rename it), which should allow us to introduce a Symlink value to the enum and use it for CreateDigest without plumbing the entirety of symlink support.

[ci skip-build-wheels]

# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

src/rust/engine/fs/src/directory.rs

# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

prefactor

a22d51b

# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

thejcannon added the category:internal CI, fixes for not-yet-released features, etc. label Sep 14, 2022

thejcannon requested review from stuhood and tdyas September 14, 2022 20:56

tdyas approved these changes Sep 14, 2022

View reviewed changes

stuhood approved these changes Sep 14, 2022

View reviewed changes

src/rust/engine/fs/src/directory.rs Outdated Show resolved Hide resolved

thejcannon added 3 commits September 14, 2022 19:42

hehe

d8a58ad

oops

ae4b579

fixes

9d1c939

# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

thejcannon merged commit bf13da9 into pantsbuild:main Sep 16, 2022

thejcannon deleted the symlink_prefactor branch September 16, 2022 00:37

wisechengyi mentioned this pull request Oct 2, 2022

Prep release 2.15.0.dev3 #17083

Merged

Provide feedback