Prefactor directory.rs
for symlink plumbing
#16872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefactoring 2 things for the upcoming symlink support:
DigestTrie.files_and_directories
intofiles
anddirectories
. The only place we used both was a__repr__
, so perf likely isn't keyDigestTrie.from_path_stats
to useTypedPath
(and rename it), which should allow us to introduce aSymlink
value to the enum and use it forCreateDigest
without plumbing the entirety of symlink support.[ci skip-build-wheels]