Every Process is now platform-specific (impacts remote caching)
#16874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
added
the
category:internal
Eric-Arellano
commented
Sep 14, 2022
There was a problem hiding this comment.
Given how unlikely cross-platform caching was to work anyways given #12203, maybe this should be a Plugin API Change rather than User API Change?
| @@ -405,7 +398,7 @@ impl ExecuteProcess { | |||
| level, | |||
| append_only_caches, | |||
| jdk_home, | |||
| platform_constraint, | |||
| platform_constraint: Some(process_config.platform), | |||
There was a problem hiding this comment.
We could simplify this to no longer be an Option, but I figured maybe it's easier to keep it in place for part 2 of #16873?
stuhood
approved these changes
Sep 14, 2022
This was referenced Sep 15, 2022
Eric-Arellano
added a commit
that referenced
this pull request
Sep 16, 2022
For Remote Execution, we currently hardcode the platform for the runner: https://github.com/pantsbuild/pants/blob/ba7566515016ab91668c3610666594844dd5e7db/src/rust/engine/src/context.rs#L204-L206 This won't work as we move to remote execution being a per-environment/process mechanism, such as via #16890. We will add remote execution environment targets, which will allow users to set different platform properties per environment, such as using different Docker images. Thus, each environment target will have a `platform` field because it may be different among them. So, the platform must come from the environment target, not a global hardcoded value. Our remote command runner doesn't like the platform being optional. In practice, it no longer was optional thanks to #16874, but our types did not reflect that. When we add back platform-agnostic processes, we will use a new field to indicate this, while still setting the platform. See #16873. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #16873, and necessary for #16852
A concrete impact of this for users is that remote cache users can now never share results between different platforms. This was already very likely though due to #12203.