-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: set platform when creating containers #16886
Conversation
[ci skip-build-wheels]
[ci skip-build-wheels]
@@ -9,7 +9,7 @@ publish = false | |||
async-stream = "0.3" | |||
async-trait = "0.1" | |||
async-lock = "2.5" | |||
bollard = { git = "https://github.com/fussybeaver/bollard.git", rev = "2e10fe31076a6e298697fc6e31fa3676b7498b6c" } | |||
bollard = { git = "https://github.com/fussybeaver/bollard.git", rev = "2d66d11b44aeff0373ece3d64a44b243e5152973" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment explaining which release/PRs we're waiting for would be helpful.
@stuhood: This |
I think so. Especially because M1s are so popular now, I think it's common users will need to set the |
[ci skip-build-wheels]
[ci skip-build-wheels]
The commit is now part of the release: fussybeaver/bollard@2d66d11 more context: pantsbuild#16886
The commit is now part of the release: fussybeaver/bollard@2d66d11 more context: #16886
Update
bollard
and make use of new ability to set platform upon container creation.For tests, the
busybox
image is only available for Linux and not macOS. Thus on macOS the tests fail since no macOS version of busybox image is available. Solve by pinning the platform used for tests to Linux. On Linux this is fine since same OS. On macOS, this works due to macOS Docker support for running Linux containers.