docker: set platform when creating containers #16886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2022 11:31
[ci skip-build-wheels]
[ci skip-build-wheels]
stuhood
approved these changes
Sep 15, 2022
| @@ -9,7 +9,7 @@ publish = false | |||
| async-stream = "0.3" | |||
| async-trait = "0.1" | |||
| async-lock = "2.5" | |||
| bollard = { git = "https://github.com/fussybeaver/bollard.git", rev = "2e10fe31076a6e298697fc6e31fa3676b7498b6c" } | |||
| bollard = { git = "https://github.com/fussybeaver/bollard.git", rev = "2d66d11b44aeff0373ece3d64a44b243e5152973" } | |||
There was a problem hiding this comment.
A comment explaining which release/PRs we're waiting for would be helpful.
|
@stuhood: This |
I think so. Especially because M1s are so popular now, I think it's common users will need to set the |
[ci skip-build-wheels]
Eric-Arellano
approved these changes
Sep 15, 2022
[ci skip-build-wheels]
asherf
added a commit
to asherf/pants
that referenced
this pull request
Apr 21, 2023
The commit is now part of the release: fussybeaver/bollard@2d66d11 more context: pantsbuild#16886
stuhood
pushed a commit
that referenced
this pull request
Apr 21, 2023
The commit is now part of the release: fussybeaver/bollard@2d66d11 more context: #16886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
bollardand make use of new ability to set platform upon container creation.For tests, the
busyboximage is only available for Linux and not macOS. Thus on macOS the tests fail since no macOS version of busybox image is available. Solve by pinning the platform used for tests to Linux. On Linux this is fine since same OS. On macOS, this works due to macOS Docker support for running Linux containers.