Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: add go-generate goal to run go generate on a package #16909

Merged
merged 7 commits into from
Sep 30, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Sep 17, 2022

Support running go generate on Go packages via new go-generate goal.

Closes #13881.

[ci skip-build-wheels]

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/python/pants/backend/go/goals/generate.py Outdated Show resolved Hide resolved
src/python/pants/backend/go/goals/generate.py Show resolved Hide resolved
src/python/pants/backend/go/goals/generate.py Show resolved Hide resolved
src/python/pants/backend/go/goals/generate.py Show resolved Hide resolved
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/python/pants/backend/go/goals/generate.py Outdated Show resolved Hide resolved
src/python/pants/backend/go/goals/generate.py Outdated Show resolved Hide resolved
Tom Dyas added 6 commits September 26, 2022 21:20
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
[ci skip-rust]

[ci skip-build-wheels]
[ci skip-rust]

[ci skip-build-wheels]
[ci skip-rust]

[ci skip-build-wheels]
[ci skip-rust]

[ci skip-build-wheels]
[ci skip-rust]

[ci skip-build-wheels]
fmt
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas requested a review from benjyw September 28, 2022 23:41
@benjyw
Copy link
Contributor

benjyw commented Sep 28, 2022

Do we want a new goal for this, vs the existing codegen mechanisms? How does this fit in with those?

@tdyas
Copy link
Contributor Author

tdyas commented Sep 29, 2022

Do we want a new goal for this, vs the existing codegen mechanisms? How does this fit in with those?

See preexisting discussion elsewhere in this PR. #16909 (comment)

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tdyas tdyas merged commit 1660336 into pantsbuild:main Sep 30, 2022
@tdyas tdyas deleted the golang_generate_goal branch September 30, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Go Go backend-related issues category:new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go: support go generate code generation
4 participants