-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few refactors of lint.py
#16940
A few refactors of lint.py
#16940
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
lint
so "PartitionKeylint
so "PartitionKey" is a first-class citizen
lint
so "PartitionKey" is a first-class citizenlint
so "PartitionKey" is a first-class citizen of "Partitions"
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
lint
so "PartitionKey" is a first-class citizen of "Partitions"lint.py
|
||
class SubPartition(Collection[_ElementT]): | ||
pass | ||
_SubPartitionBase = SubPartition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are required so we can use them as the "base" class. Otherwise we'd hit an infinite recursion trying to lookup the class.
Unrelated to this one in particular, but: it looks like
|
It has taken me until today to actually realize why I'll fix it in the |
The big changes are:
Partitions
a mapping from key -> partition (with the key option for single partitions. Will beNone
)[ci skip-build-sheels]
[ci skip-rust]