Prefactor lint for upcoming fmt changes #16964
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
thejcannon
added
the
category:internal
src/python/pants/core/goals/lint.py
Outdated
| @@ -637,7 +643,7 @@ def key(fs: FieldSet) -> str: | |||
| return Lint(_get_error_code(all_batch_results)) | |||
|
|
|||
|
|
|||
| @rule(level=LogLevel.DEBUG) | |||
| @rule(level=LogLevel.TRACE) | |||
There was a problem hiding this comment.
Why is this necessary to set? It should default to TRACE
There was a problem hiding this comment.
Ohhh I misunderstood why we were seeing the message. LintResult is a EngineAwareReturnType whose level is INFO.
Hmmm....
There was a problem hiding this comment.
I've undone the change. If we can stomach seeing the annoying message a bit longer, I have a future change I plan on implementing after the fmt refactor which as I shared with Stu in DM:
My plan to not make LintResult streaming, and use a another rule (like this one) which converts a LintResult into a StreamedLintResult. The difference is right now we force plugin authors to plumb the input snapshot and tool name into LintResult. New change will have that in StreamedLintResult , but not LintResult.
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
I had to move the batching out of the helper. In |
Prefactoring
lint.pyin a few ways:rule_helperwhich will comprise of most oflintandfmtblackfor files and targets).[ci skip-rust]
[ci skip-build-wheels]