Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: use templating library for coverage setup code #16996

Merged
merged 1 commit into from
Sep 30, 2022
Merged

go: use templating library for coverage setup code #16996

merged 1 commit into from
Sep 30, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Sep 25, 2022 •
edited
Loading

Use the chevron templating library which is already in the Pants lockfile to process Go coverage setup code as a template instead of the bespoke string substitution currently performed.

[ci skip-build-wheels]

@tdyas tdyas added backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc. labels Sep 25, 2022
Eric-Arellano
Eric-Arellano approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, it's not great to add new dependencies to Pants because it slows down CI for everyone using us since the Pants venv needs to download more things. But given that this is a pure Python wheel and only 11.4 kB, I think it's reasonable.

@tdyas tdyas merged commit 001a1ab into pantsbuild:main Sep 30, 2022
@tdyas tdyas deleted the golang_coverage_use_chevron branch September 30, 2022 22:15
@wisechengyi wisechengyi mentioned this pull request Oct 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@stuhood stuhood Awaiting requested review from stuhood

@benjyw benjyw Awaiting requested review from benjyw

Assignees
No one assigned
Labels
backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdyas @Eric-Arellano