Fix Pantsd not properly invalidating when CPPFLAGS and LDFLAGS change
#17009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iously # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
chrisjrn
added
the
category:internal
|
I think I can do better than needing yet another data type and manually creating rules, but don't let that get in the way of reviewing this. |
Eric-Arellano
approved these changes
Sep 26, 2022
chrisjrn
added
category:bugfix
chrisjrn
changed the title
python-native-code envvars using EnvironmentVarsCPPFLAGS and LDFLAGS change
chrisjrn
pushed a commit
that referenced
this pull request
Sep 27, 2022
This extends #17009 by making a generic mechanism to request environment variables when `EnvironmentAware` subsystems are constructed. Generally speaking, this encapsulates both the requesting and consumption of environment variables into the subsystem itself, and this will save subsystem consumers from knowing which environment variables to request in order to call an option post-processing method. All option post-processing methods should safely be able to be converted to properties too. All very exciting. Fixes #14612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
PythonNativeCodeEnvironment, a value created by a rule that encapsulates the environment var fetching needed to makePythonNativeCodeSubsystem.EnvironmentAwareresolve correctly.Fixes #14612