Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JVM resources jar file to be deterministic by default (Cherry-pick of #16950) #17032

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Fix JVM resources jar file to be deterministic by default (Cherry-pick of #16950) #17032

merged 3 commits into from
Sep 28, 2022

Commits on Sep 27, 2022

  1. Fix JVM resources jar file to be determinstic by default (pantsbuild#… 

    …16950)

At the moment, java or scala projects won't benefit much from the remote cache because the resources jar local process file will usually win the remote cache read. As zip is non-deterministic, which means that the resources jar file would invalidate any dependents in the graph.

Using reproducible_jars would solve that, but the price would be running the strip jar for all jars.

This PR solves this by changing the dates of all the files in the zip file before archiving.

[ci skip-rust]
[ci skip-build-wheels]
    @somdoron @Eric-Arellano
    somdoron authored and Eric-Arellano committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    f3bdd0b View commit details
    Browse the repository at this point in the history

  2. Fix missing 'f' literal in resources process (pantsbuild#17026) 

    [ci skip-rust]
[ci skip-build-wheels]
    @somdoron @Eric-Arellano
    somdoron authored and Eric-Arellano committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    e2071ac View commit details
    Browse the repository at this point in the history

  3. Fix bad test import 

    # Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @Eric-Arellano
    Eric-Arellano committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a9f6836 View commit details
    Browse the repository at this point in the history