Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] dogfood local environments for pantsbuild/pants #17043

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,14 @@ files(name="files", sources=["BUILD_ROOT", "pants.toml"])
python_test_utils(name="test_utils")

_local_environment(
name="default_env",
name="linux_env",
compatible_platforms=["linux_arm64", "linux_x86_64"],
)

_local_environment(
name="macos_ci_env",
compatible_platforms=["macos_arm64", "macos_x86_64"],
python_bootstrap_search_path=["<PATH>"],
)

_local_environment(
Expand Down
4 changes: 4 additions & 0 deletions pants.ci.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ colors = true
remote_cache_read = true
remote_cache_write = true

[environments-preview.names.add]
# Override what macos refers to.
macos = "//:macos_ci_env"

[test]
use_coverage = true

Expand Down
6 changes: 2 additions & 4 deletions pants.toml
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,8 @@ root_patterns = [
]

[environments-preview.names]
default_env = "//:default_env"
# TODO(#7735): Define `//:macos_local_env` after figuring out why our Build Wheels Mac job is
# failing when this is set:
# https://github.com/pantsbuild/pants/runs/8082954359?check_suite_focus=true#step:9:657
linux = "//:linux_env"
macos = "//:macos_local_env"
docker = "//:docker_env"

[tailor]
Expand Down