Make interpreter path expansion cache-correct #17051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjrn
changed the title
chrisjrn
added
the
category:internal
|
(Moved back to draft status while I address ASDF in the same PR. Apparently |
Eric-Arellano
approved these changes
Sep 29, 2022
|
This is probably "bugfix" - it impacts users for existing features |
|
Eugh, looks like I do need to make the |
|
@Eric-Arellano Agreed, I'll change that over momentarily |
added 6 commits
September 29, 2022 15:47
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
… from elsewhere # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
chrisjrn
added
category:bugfix
chrisjrn
force-pushed
the
chrisjrn/make-expansion-cache-efficient
branch
from
8f365d7
to
7d52aa6
Compare
Eric-Arellano
approved these changes
Sep 29, 2022
| raise ValueError( | ||
| softwrap( | ||
| f"`[python-bootstrap].search_paths` is configured to use local Go discovery " | ||
| f"tools, which do not work in {env_type.__name__} runtime environments. To fix " |
There was a problem hiding this comment.
this should probably instead be env_target.alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion with @stuhood, it emerged that none of the filesystem-sensitive code in
python_bootstrapis cache-correct, in that the functions that hit the filesystem were not markeduncacheable.This PR refactors
_expand_interpreter_search_pathsand_get_pyenv_pathsinto rules, marking_get_pyenv_pathsas uncacheable. This reduces the footprint of the sandbox-unsafe code to just_get_pyenv_paths.It also reduces the scope of
AsdfToolPathsRequest, and moves the point where it is requested to inside the path expansion rule, and only ifasdfis actually requested.Closes #16800.