Retry the streaming portion of downloads, as well as the setup. (Cherry-pick of #17298) #17302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Oct 21, 2022
stuhood
force-pushed
the
cherry-pick-17298-to-2.14.x
branch
from
2c61584
to
0980643
Compare
This comment was marked as resolved.
This comment was marked as resolved.
stuhood
force-pushed
the
cherry-pick-17298-to-2.14.x
branch
2 times, most recently
from
8f830db
to
4015bef
Compare
…sbuild#17298) As reported in pantsbuild#17294, if an HTTP stream is interrupted after it has opened, the retry that was added in pantsbuild#16798 won't kick in. This change moves the retry up a level to wrap the entire download attempt, and adds a test of recovering from "post-header" errors. Fixes pantsbuild#17294. [ci skip-build-wheels]
stuhood
force-pushed
the
cherry-pick-17298-to-2.14.x
branch
from
4015bef
to
8af762a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #17294, if an HTTP stream is interrupted after it has opened, the retry that was added in #16798 won't kick in.
This change moves the retry up a level to wrap the entire download attempt, and adds a test of recovering from "post-header" errors.
Fixes #17294.