Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leftover todo!() #17523

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Fix leftover todo!() #17523

merged 4 commits into from
Nov 11, 2022

Conversation

thejcannon
Copy link
Member

@thejcannon thejcannon commented Nov 10, 2022 •
edited
Loading

Fixes the TODO by making subsetting always oblivious

@thejcannon thejcannon added the category:internal CI, fixes for not-yet-released features, etc. label Nov 10, 2022
stuhood
stuhood approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/rust/engine/fs/store/src/snapshot_ops.rs Show resolved Hide resolved
@thejcannon thejcannon merged commit 27f9da9 into pantsbuild:main Nov 11, 2022
@thejcannon thejcannon deleted the fixtodo branch November 11, 2022 19:23
@stuhood stuhood mentioned this pull request Nov 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@tdyas tdyas Awaiting requested review from tdyas

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thejcannon @stuhood @Eric-Arellano