correct docs: direnv can't save ulimit #17561
Conversation
direnv can only cache env variables, not ulimit settings
michaelglass
changed the title
| @@ -233,8 +233,7 @@ This can be fixed by setting `ulimit -n 10000`. (10,000 should work in all cases | |||
| > We recommend permanently setting this by either: | |||
| > | |||
| > 1. Adding `ulimit -n 10000` to your `./pants` script. | |||
There was a problem hiding this comment.
Oh, while being here, I think we might as well update the recommendation to patch the ./pants script to instead refer to the .pants.bootstrap script as a means to patch the pants runtime env, if you don't mind :)
Perfectly fine if not, I wasn't aware of this patching pants script being a thing in the docs.
There was a problem hiding this comment.
| > 1. Adding `ulimit -n 10000` to your `./pants` script. | |
| > 1. Adding `ulimit -n 10000` to your `./pants.bootstrap` script. |
There was a problem hiding this comment.
Thanks, minor nit, there's a missing leading . on the file name :)
There was a problem hiding this comment.
@Eric-Arellano oops, I missed this convo was marked as resolved..
There was a problem hiding this comment.
Oh, this is supposed to be ./pants bootstrap script?
There was a problem hiding this comment.
No, it was, I suggested this change, but he missed the leading dot, so ./.pants.bootstrap.
There was a problem hiding this comment.
whoops. sorry folks
There was a problem hiding this comment.
@michaelglass no worries, it was a double-miss between me and Eric :)
| @@ -233,8 +233,7 @@ This can be fixed by setting `ulimit -n 10000`. (10,000 should work in all cases | |||
| > We recommend permanently setting this by either: | |||
| > | |||
| > 1. Adding `ulimit -n 10000` to your `./pants` script. | |||
There was a problem hiding this comment.
Thanks, minor nit, there's a missing leading . on the file name :)
|
Thanks for making Pants better! |
direnv can only cache env variables, not ulimit settings
see direnv/direnv#777