[internal] Replace bespoke explorer dependency rules with new visibility rules

pants.toml

@@ -30,6 +30,7 @@ backend_packages.add = [
   "pants.backend.experimental.scala",
   "pants.backend.experimental.scala.lint.scalafmt",
   "pants.backend.experimental.scala.debug_goals",
+  "pants.backend.experimental.visibility",
   "internal_plugins.releases",
   "internal_plugins.test_lockfile_fixtures",
 ]

src/python/pants/backend/explorer/BUILD

@@ -21,3 +21,15 @@ python_tests(
     name="tests",
     dependencies=[":explorer"],
 )
+
+
+__dependents_rules__(
+    # Block any outside sources from pulling in code from this backend, as it is self contained and
+    # have 3rd party dependencies that we don't want to leak to the core Pants distribution.
+    (
+        "*",
+        build_file_dir(),
+        build_file_dir() / "*",
+        "!*",
+    ),
+)

src/python/pants/backend/explorer/graphql/query/conftest.py

@@ -10,7 +10,6 @@
 from pants.backend.docker.target_types import DockerImageTarget
 from pants.backend.explorer.graphql.rules import rules
 from pants.backend.explorer.graphql.setup import create_schema
-from pants.backend.explorer.rules import validate_explorer_dependencies
 from pants.backend.project_info import peek
 from pants.engine.environment import EnvironmentName
 from pants.engine.explorer import RequestState
@@ -57,7 +56,6 @@ def fake_consumed_scopes_mapper(scope: str) -> tuple[str, ...]:
 def rule_runner() -> RuleRunner:
     return RuleRunner(
         rules=(
-            validate_explorer_dependencies,
             *peek.rules(),
             *rules(),
         ),

src/python/pants/backend/explorer/graphql/query/rules_test.py

@@ -13,7 +13,6 @@
             {"name": r"\.explorer\."},
             {
                 "rules": [
-                    {"name": "pants.backend.explorer.rules.validate_explorer_dependencies"},
                     {"name": "pants.backend.explorer.graphql.rules.get_graphql_uvicorn_setup"},
                 ]
             },
@@ -27,12 +26,8 @@
             },
         ),
         (
-            {"limit": 1},
-            {
-                "rules": [
-                    {"name": "pants.backend.explorer.rules.validate_explorer_dependencies"},
-                ]
-            },
+            {"limit": 0},
+            {"rules": []},
         ),
         (
             {"limit": 0},

src/python/pants/backend/explorer/register.py

@@ -4,15 +4,13 @@
 from __future__ import annotations
 
 from pants.backend.explorer import browser
-from pants.backend.explorer import rules as explorer
 from pants.backend.explorer.graphql import rules as graphql
 from pants.backend.explorer.server import uvicorn
 
 
 def rules():
     return (
         *browser.rules(),
-        *explorer.rules(),
         *graphql.rules(),
         *uvicorn.rules(),
     )

src/python/pants/backend/visibility/rule_types.py

@@ -7,6 +7,7 @@
 import os.path
 from dataclasses import dataclass, field
 from fnmatch import fnmatch, fnmatchcase
+from pathlib import PurePath
 from typing import Any, Iterable, Iterator, Sequence, cast
 
 from pants.engine.internals.dep_rules import (
@@ -67,7 +68,7 @@ def flatten(xs) -> Iterator[str]:
         yield xs
     elif isinstance(xs, Iterable):
         yield from itertools.chain.from_iterable(flatten(x) for x in xs)
-    elif type(xs).__name__ == "Registrar":
+    elif type(xs).__name__ == "Registrar" or isinstance(xs, PurePath):
         yield str(xs)
     else:
         raise ValueError(f"expected a string but got: {xs!r}")

src/python/pants/backend/visibility/rule_types_test.py

@@ -4,6 +4,7 @@
 from __future__ import annotations
 
 import logging
+from pathlib import PurePath
 from textwrap import dedent
 from typing import Any
 
@@ -71,6 +72,10 @@
                 ),
             ),
         ),
+        (
+            ["src/test"],
+            PurePath("src/test"),
+        ),
     ],
 )
 def test_flatten(expected, xs) -> None: