Get all tests passing on linux arm64 #17645
Conversation
1) Switches spectral to be an NpxTool, since there is no published binary for arm64. 2) Add terraform versions for Linux arm64.
benjyw
changed the title
|
With these changes
|
| "linux_arm64": "linux", | ||
| "linux_x86_64": "linux", | ||
| } | ||
| default_version = "@stoplight/spectral-cli@6.5.1" |
There was a problem hiding this comment.
This is an experimental backend, so we can break the semantics of this version string, and note that this backend will only be available in 2.15, and this change will be in place in 2.16, so the incompatibility window is narrow.
| @@ -315,8 +315,10 @@ def test_coverage_html_xml_json_lcov(batched: bool) -> None: | |||
| def test_default_coverage_issues_12390() -> None: | |||
| # N.B.: This ~replicates the repo used to reproduce this issue at | |||
| # https://github.com/alexey-tereshenkov-oxb/monorepo-coverage-pants. | |||
| if platform.system() == "Darwin" and platform.processor() == "arm": | |||
There was a problem hiding this comment.
It turns out that platform.processor() is an empty string on Linux ARM64, and in general machine() is preferred.
| from pants.testutil.pants_integration_test import run_pants, setup_tmpdir | ||
|
|
||
| skip_on_linux_arm = pytest.mark.skipif( | ||
| platform.system() == "Linux" and platform.machine() == "aarch64", | ||
| reason="PyOxidizer is not supported on Linux ARM", |
There was a problem hiding this comment.
I was surprised too, but https://pyoxidizer.readthedocs.io/en/pyoxidizer-0.17/pyoxidizer_getting_started.html:
PyOxidizer is officially supported on the following operating systems:
- Windows x86 (32-bit)
- Windows x86_64/amd64 (64-bit)
- macOS x86_64 (Intel processors)
- macOS aarch64 (ARM/Apple processors)
- Linux i686 (32-bit)
- Linux x86_64 (64-bit)
|
What's this |
|
Eeeerk, I thought I had deleted that. 🤦 That was an artifact of connecting to the temporary EC2 instance I was using for testing. I have deleted the underlying instance and key pairs, and this is a public key box, so not a security issue. Will delete these from the repo. |
Once we have resources to run Linux arm64 CI we can start releasing wheels for that platform.