Always provide Python-for-Pants-scripts #18433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
commented
Mar 7, 2023
| ), | ||
| ) | ||
|
|
||
| result = await Get( |
There was a problem hiding this comment.
NB: I can't use ExternalTool due to a circular reference: ExternalTool -> ExtractArchive -> Gunzip -> (This).
thejcannon
commented
Mar 7, 2023
|
If someone wants to educate me on the easiest way to test the rule-in-docker code, please do. Otherwise I'll start searching other tests. |
thejcannon
changed the title
thejcannon
commented
Mar 7, 2023
stuhood
approved these changes
Mar 7, 2023
thejcannon
added a commit
to thejcannon/pants
that referenced
this pull request
Mar 14, 2023
This PR decouples the Python Pants uses for its own nefarious purposes (like running PEX or `gunzip`) from the user search paths by either using `sys.executable` locally or downloading and using Python Build Standalone in a Docker environment. Additionally when making this change, the Python/pex code was refactored so that we always use this Python to run pex, with Python either being chosen by pex, or by using `PEX_PYTHON` env var at runtime. I think this is a nice cleanup of the handshake between `CompletePexEnvironment.create_argv` and `CompletePexEnvironment.environment_dict` used to have. On a side note, this (with `scie-pants` and pantsbuild#18352) this marks a complete divorce from any Python on the user system (or lack thereof) and running Python code.
thejcannon
added a commit
that referenced
this pull request
Mar 14, 2023
This PR decouples the Python Pants uses for its own nefarious purposes (like running PEX or `gunzip`) from the user search paths by either using `sys.executable` locally or downloading and using Python Build Standalone in a Docker environment. Additionally when making this change, the Python/pex code was refactored so that we always use this Python to run pex, with Python either being chosen by pex, or by using `PEX_PYTHON` env var at runtime. I think this is a nice cleanup of the handshake between `CompletePexEnvironment.create_argv` and `CompletePexEnvironment.environment_dict` used to have. On a side note, this (with `scie-pants` and #18352) this marks a complete divorce from any Python on the user system (or lack thereof) and running Python code.
This was referenced May 27, 2023
stuhood
added a commit
that referenced
this pull request
Jun 1, 2023
This should've been done in #18433 but wasn't. Same for the removal of the Gunzip cruft. It was supposed to be moved in that PR, but was only added. --------- Co-authored-by: Stu Hood <stuhood@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
This should've been done in #18433 but wasn't. Same for the removal of the Gunzip cruft. It was supposed to be moved in that PR, but was only added. --------- Co-authored-by: Stu Hood <stuhood@gmail.com>
thejcannon
added a commit
that referenced
this pull request
Jun 7, 2023
This should've been done in #18433 but wasn't. Same for the removal of the Gunzip cruft. It was supposed to be moved in that PR, but was only added. --------- Co-authored-by: Joshua Cannon <joshdcannon@gmail.com> Co-authored-by: Stu Hood <stuhood@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the Python Pants uses for its own nefarious purposes (like running PEX or
gunzip) from the user search paths by either usingsys.executablelocally or downloading and using Python Build Standalone in a Docker environment.Additionally when making this change, the Python/pex code was refactored so that we always use this Python to run pex, with Python either being chosen by pex, or by using
PEX_PYTHONenv var at runtime. I think this is a nice cleanup of the handshake betweenCompletePexEnvironment.create_argvandCompletePexEnvironment.environment_dictused to have.On a side note, this (with
scie-pantsand #18352) this marks a complete divorce from any Python on the user system (or lack thereof) and running Python code.