-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the pants-pyenv-install
target to a sub-plugin
#18499
Conversation
Thanks for deferring this from #18352, as I continue to think this implementation is a bit contorted. As mentioned in #18352 (comment), I think that providing a way to pass environment variables / flags to
As mentioned elsewhere, I won't block though. |
4 I'm skeptical about. I'm very weary about unecessary re-installs (especially since this can't be cached), especially if a 30-minute install process is at stake. I think in the end, I don't see a way around giving the user a level to pull on their own, when ready, to prime their cache in such a timesink way. |
How would a user know that they need to re-run the magical step after a Pants version or Python version change had occurred? Their changes would just disappear. |
Yeah OK the "I always want optimized Python" people aren't completely solved here. It's helpful to have this lever to pull, but it isn't obvious when it needs to be pulled. My surface level thought here is maybe an extra option for "error and bail if you would install Python, I wanna do it myself". I'll think on it though. |
This was leftover from the prior PR, but split the magic into an opt-in plugin. I also added tests for it, yay. Expected usage (which will be documented) is: `ENVVAR1=blah pants --concurrent --backend-packages=pants.backend.python.providers.experimental.pyenv.custom_install run :pants-pyenv-install -- 3.9`
…18499) (#18744) This was leftover from the prior PR, but split the magic into an opt-in plugin. I also added tests for it, yay. Expected usage (which will be documented) is: `ENVVAR1=blah pants --concurrent --backend-packages=pants.backend.python.providers.experimental.pyenv.custom_install run :pants-pyenv-install -- 3.9`
This was leftover from the prior PR, but split the magic into an opt-in plugin. I also added tests for it, yay.
Expected usage (which will be documented) is:
ENVVAR1=blah pants --concurrent --backend-packages=pants.backend.python.providers.experimental.pyenv.custom_install run :pants-pyenv-install -- 3.9