Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb entire lockfile/internal only code through create_pex_from_targets (Cherry-pick of #18622) #18634

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Plumb entire lockfile/internal only code through create_pex_from_targets (Cherry-pick of #18622) #18634

merged 1 commit into from
Mar 31, 2023

Commits on Mar 31, 2023

  1. Plumb entire lockfile/internal only code through `create_pex_from_tar… 

    …gets` (pantsbuild#18622)

Previously if `_determine_requirements_for_pex_from_targets` returns a
`PexRequest` we'd short-circuit the rest of of the code resulting in
`main` not being set on the PEX that we run (most likely in addition to
other bugs like local dists not existing either).

Refactored so that in this very specific case, we'd still make it
through the rest of the code, leveraging `pex_path` for the repo PEX.

Fixes pantsbuild#18552
    @thejcannon @benjyw
    thejcannon authored and benjyw committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    8fc39d9 View commit details
    Browse the repository at this point in the history