refactor package_python_dist rule so most of the logic can be reused (Cherry-pick of #18701)
#18703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
added
category:internal
Eric-Arellano
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18639, I have a change to allow pants to do editable installs of
python_distributions for in exported-mutable virtualenvs of user code.I need all of the dist chroot setup that happens in the
package_python_distrule, so I extracted everything that createsDistBuildRequestinto a separate helper function.I would like this light refactoring to end up in 2.16.x so that I can implement #18639 as a plugin for 2.16.x, while waiting for #18639 to be merged and then released in a 2.17.x version.