Optimize Target and FieldSet operations
#18917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is apparently not cheap).
…edundant `Target.plugin_types` property.
stuhood
force-pushed
the
stuhood/target-and-field-set-opts
branch
from
4379dd1 to
68ce5d4
Compare
|
Commits are useful to review independently. |
benjyw
pushed a commit
to benjyw/pants
that referenced
this pull request
May 9, 2023
Recent profiles (from pantsbuild#18911, and reproduced locally) highlighted: * `FieldSet.create` was repeatedly calling the unmemoized `_get_field_set_fields`, which used the surprisingly expensive `from typing import get_type_hints`. * This change moves type hint extraction into a memoized property. * `Target.has_fields` was doing an N^2 lookup of fields in a computed collection of registered fields. * Moved to using the `field_values` `dict` to represent the set of present fields, and removed the `plugin_fields` property (which is always incorporated into the `field_values` at construction time anyway). ---- Performance for `./pants --no-pantsd dependencies ::` in `pantsbuild/pants` improves by 9% (or 15%, if the time for rule graph solving is ignored).
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
May 9, 2023
Recent profiles (from pantsbuild#18911, and reproduced locally) highlighted: * `FieldSet.create` was repeatedly calling the unmemoized `_get_field_set_fields`, which used the surprisingly expensive `from typing import get_type_hints`. * This change moves type hint extraction into a memoized property. * `Target.has_fields` was doing an N^2 lookup of fields in a computed collection of registered fields. * Moved to using the `field_values` `dict` to represent the set of present fields, and removed the `plugin_fields` property (which is always incorporated into the `field_values` at construction time anyway). ---- Performance for `./pants --no-pantsd dependencies ::` in `pantsbuild/pants` improves by 9% (or 15%, if the time for rule graph solving is ignored).
benjyw
added a commit
that referenced
this pull request
May 9, 2023
) Recent profiles (from #18911, and reproduced locally) highlighted: * `FieldSet.create` was repeatedly calling the unmemoized `_get_field_set_fields`, which used the surprisingly expensive `from typing import get_type_hints`. * This change moves type hint extraction into a memoized property. * `Target.has_fields` was doing an N^2 lookup of fields in a computed collection of registered fields. * Moved to using the `field_values` `dict` to represent the set of present fields, and removed the `plugin_fields` property (which is always incorporated into the `field_values` at construction time anyway). ---- Performance for `./pants --no-pantsd dependencies ::` in `pantsbuild/pants` improves by 9% (or 15%, if the time for rule graph solving is ignored). --------- Co-authored-by: Stu Hood <stuhood@gmail.com>
stuhood
added a commit
that referenced
this pull request
May 9, 2023
…18949) Recent profiles (from #18911, and reproduced locally) highlighted: * `FieldSet.create` was repeatedly calling the unmemoized `_get_field_set_fields`, which used the surprisingly expensive `from typing import get_type_hints`. * This change moves type hint extraction into a memoized property. * `Target.has_fields` was doing an N^2 lookup of fields in a computed collection of registered fields. * Moved to using the `field_values` `dict` to represent the set of present fields, and removed the `plugin_fields` property (which is always incorporated into the `field_values` at construction time anyway). ---- Performance for `./pants --no-pantsd dependencies ::` in `pantsbuild/pants` improves by 9% (or 15%, if the time for rule graph solving is ignored).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent profiles (from #18911, and reproduced locally) highlighted:
FieldSet.createwas repeatedly calling the unmemoized_get_field_set_fields, which used the surprisingly expensivefrom typing import get_type_hints.Target.has_fieldswas doing an N^2 lookup of fields in a computed collection of registered fields.field_valuesdictto represent the set of present fields, and removed theplugin_fieldsproperty (which is always incorporated into thefield_valuesat construction time anyway).Performance for
./pants --no-pantsd dependencies ::inpantsbuild/pantsimproves by 9% (or 15%, if the time for rule graph solving is ignored).