-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial CODEOWNERS with me #18953
Conversation
There's also https://github.com/gagoar/codeowners-generator if y'all wanna go that route. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be in the root, where it's more obvious (github supports this).
It's too bad there can't be local CODEOWNERS that override the values for the dirs they're in. But I bet they will add this some time.
Have you seen https://github.com/gagoar/codeowners-generator? |
Interesting, although probably overkill for us for now. I'd just move it to the repo root though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not familiar with CODEOWNERS in particular, but this looks interesting.
If it's all the same, I prefer this location because I dislike the proliferation of root-level files |
Merged. I hope to see more PRs come in as people claim more sections of the repo 🎉 |
Up to you, but FWIW I disagree: this is exactly the kind of file we should want at the root level. |
Can you elaborate, I'm missing the "why" |
Because |
Does someone normally go sniffing in CODEOWNERS files for info? I like this isolated in .github because it is 100% a GitHub-only feature |
I dunno, TBH, I've never used CODEOWNERS before. But I imagine it could be useful to manually figure out who owns a piece of code, e.g., who to ask questions. But then maybe this is more useful with codeowners-generator source files than with this regex-based thing. |
I have no hard preference either way here, but for this particular point I think a sensible answer would be to reach out on Slack #development possibly tagging someone, but open for anyone to jump in as well. Need more than that there's also I consider this file to be for tooling, and if you want to consume it for other purposes that's fine too, but doesn't make sense to influence its life over (to me). |
Looking for sign-off on the idea and the preamble.
If you want your name on the file itself, let me know. You can open a follow-up PR as well.