Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial CODEOWNERS with me #18953

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

thejcannon
Copy link
Member

Looking for sign-off on the idea and the preamble.

If you want your name on the file itself, let me know. You can open a follow-up PR as well.

@thejcannon thejcannon added the category:internal CI, fixes for not-yet-released features, etc. label May 9, 2023
@thejcannon
Copy link
Member Author

There's also https://github.com/gagoar/codeowners-generator if y'all wanna go that route.

Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be in the root, where it's more obvious (github supports this).

It's too bad there can't be local CODEOWNERS that override the values for the dirs they're in. But I bet they will add this some time.

@thejcannon
Copy link
Member Author

It's too bad there can't be local CODEOWNERS that override the values for the dirs they're in.

Have you seen https://github.com/gagoar/codeowners-generator?

@benjyw
Copy link
Contributor

benjyw commented May 9, 2023

Interesting, although probably overkill for us for now. I'd just move it to the repo root though.

Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with CODEOWNERS in particular, but this looks interesting.

@thejcannon
Copy link
Member Author

If it's all the same, I prefer this location because I dislike the proliferation of root-level files

@thejcannon thejcannon merged commit 049843f into pantsbuild:main May 10, 2023
@thejcannon thejcannon deleted the CODEOWNERS branch May 10, 2023 01:34
@thejcannon
Copy link
Member Author

Merged. I hope to see more PRs come in as people claim more sections of the repo 🎉

@benjyw
Copy link
Contributor

benjyw commented May 10, 2023

Up to you, but FWIW I disagree: this is exactly the kind of file we should want at the root level.

@thejcannon
Copy link
Member Author

Can you elaborate, I'm missing the "why"

@benjyw
Copy link
Contributor

benjyw commented May 10, 2023

Because .github is an obscure hidden directory, and I will not think to look in it for anything. But it's fine this way too, if it becomes a problem we can move it in the future.

@thejcannon
Copy link
Member Author

Does someone normally go sniffing in CODEOWNERS files for info?

I like this isolated in .github because it is 100% a GitHub-only feature

@benjyw
Copy link
Contributor

benjyw commented May 10, 2023

I dunno, TBH, I've never used CODEOWNERS before. But I imagine it could be useful to manually figure out who owns a piece of code, e.g., who to ask questions. But then maybe this is more useful with codeowners-generator source files than with this regex-based thing.

@kaos
Copy link
Member

kaos commented May 10, 2023

I dunno, TBH, I've never used CODEOWNERS before. But I imagine it could be useful to manually figure out who owns a piece of code, e.g., who to ask questions. But then maybe this is more useful with codeowners-generator source files than with this regex-based thing.

I have no hard preference either way here, but for this particular point I think a sensible answer would be to reach out on Slack #development possibly tagging someone, but open for anyone to jump in as well. Need more than that there's also git blame.

I consider this file to be for tooling, and if you want to consume it for other purposes that's fine too, but doesn't make sense to influence its life over (to me).

@stuhood stuhood mentioned this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants