Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS: add @kaos to a few places. #18967

Merged
merged 3 commits into from
May 10, 2023
Merged

CODEOWNERS: add @kaos to a few places. #18967

merged 3 commits into from
May 10, 2023

Conversation

kaos
Copy link
Member

@kaos kaos commented May 10, 2023

It's a start.

@kaos kaos added the category:internal CI, fixes for not-yet-released features, etc. label May 10, 2023
@kaos kaos requested a review from thejcannon as a code owner May 10, 2023 13:13
thejcannon
thejcannon approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@thejcannon thejcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also FYI with CODEOWNERS there can be multiple. WHich we likely ought to do to respect OoO from a single person.

All in good time though

.github/CODEOWNERS Outdated Show resolved Hide resolved
@kaos kaos enabled auto-merge (squash) May 10, 2023 15:05
@kaos
Copy link
Member Author

kaos commented May 10, 2023

Also FYI with CODEOWNERS there can be multiple. WHich we likely ought to do to respect OoO from a single person.

All in good time though

Certainly. Also to avoid looking like any single part of the repo is "owned" by some individual alone. The GH UI does make it come across a bit territorial imo which is a bit unfortunate but.. oh well.

@kaos kaos merged commit df749c1 into pantsbuild:main May 10, 2023
@stuhood stuhood mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejcannon thejcannon thejcannon approved these changes

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaos @thejcannon