Apply taplo to the repository #18998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaos
approved these changes
May 15, 2023
thejcannon
reviewed
May 15, 2023
There was a problem hiding this comment.
For the record, here's the available options:
https://taplo.tamasfe.dev/configuration/formatter-options.html
column_width is likely something to bikeshed discuss.
reorder_keys might be interesting to turn on 🤔
|
@thejcannon Is this something we're interested in merging at this time or should I close it? |
|
Oh, yeah totally interested 😄 Mind upgrading the version to one which has the fix from tamasfe/taplo#404? |
thejcannon
approved these changes
Jun 6, 2023
benjyw
approved these changes
Jun 6, 2023
cognifloyd
approved these changes
Jun 6, 2023
Eric-Arellano
approved these changes
Jun 6, 2023
|
I'd like to see line length 100 to match our config for black/isort. |
|
I'm enabling auto-merge and will monitor the build. BIG BIG BIG BIG BIG thanks @bryanwweber ❤️ |
|
Happy to help <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the suggestion from @thejcannon, I've turned the taplo formatter onto pants itself 😄 Happy to take suggestions for formatting standards, if anyone wants to bikeshed.