Move disabling the native-client into the native client itself #19010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On pantsbuild/scie-pants#172, @jsirois pointed out that allowing the native-client to handle disabling itself (if requested) would be much cleaner from a
scie-pants
perspective, and keepingscie-pants
as small and simple as possible is an important goal.This change moves
PANTS_NO_NATIVE_CLIENT
handling into the native client.