Move disabling the native-client into the native client itself #19010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
added
the
category:internal
jsirois
approved these changes
May 15, 2023
stuhood
force-pushed
the
stuhood/native-client-self-fallback
branch
from
ad851dd
to
85d2c8a
Compare
stuhood
added a commit
to pantsbuild/scie-pants
that referenced
this pull request
May 15, 2023
This change uses the `native-client` binary included in `pantsbuild/pants` wheels by pantsbuild/pants#18957 (and further adjusted in pantsbuild/pants#19010) to launch `pants`. See that change for the performance impact.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On pantsbuild/scie-pants#172, @jsirois pointed out that allowing the native-client to handle disabling itself (if requested) would be much cleaner from a
scie-pantsperspective, and keepingscie-pantsas small and simple as possible is an important goal.This change moves
PANTS_NO_NATIVE_CLIENThandling into the native client.